From: Patrick McHardy <kaber@trash.net>
To: Jarek Poplawski <jarkao2@gmail.com>
Cc: David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, Herbert Xu <herbert@gondor.apana.org.au>
Subject: Re: [PATCH 0/6] Add qdisc->ops->peek() support.
Date: Thu, 16 Oct 2008 14:38:31 +0200 [thread overview]
Message-ID: <48F735C7.6050808@trash.net> (raw)
In-Reply-To: <20081016094645.GA19019@ff.dom.local>
Jarek Poplawski wrote:
> So here is my try (I hope I didn't miss Patrick's intentions to much).
>
> PATCH 6/6 adds my simple idea not to prevent even nonsense configs.
> It is optional.
These patches look good to me. About 6/6, I'm still thinking we
might want to prevent certain kinds of nonsensical configurations
for simplicity. Its a bit similar to the multiq stuff, a lot of
these complications came from the fact that non-work-conserving
qdiscs, which require a global view, are treated similar to work-
conserving ones. I don't have a good scheme worked out though,
so for now using your patch seems OK too.
> PS: after this patchset only netem_enqueue() needs qdisc->requeue(),
> but I hope this won't take too long.
Assuming work-conserving qdiscs are used with netem, the currently
code will always send out a reorder packet immediately. This behaviour
is trivial to implement without ->requeue. The problematic case is
non-work-conserving inner qdiscs, but that doesn't seem important
at all since you'd usually add it as parent of netem, which still
works.
next prev parent reply other threads:[~2008-10-16 12:38 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-16 9:46 [PATCH 0/6] Add qdisc->ops->peek() support Jarek Poplawski
2008-10-16 12:38 ` Patrick McHardy [this message]
2008-10-16 13:08 ` Jarek Poplawski
2008-10-16 22:09 ` Jarek Poplawski
2008-10-17 12:33 ` Patrick McHardy
2008-10-17 13:03 ` Jarek Poplawski
2008-10-17 14:12 ` Patrick McHardy
2008-10-17 20:12 ` [PATCH] pkt_sched: sch_netem: Limit packet re-ordering functionality to tfifo qdisc Jarek Poplawski
2008-10-21 23:36 ` David Miller
2008-10-21 23:51 ` Stephen Hemminger
2008-10-22 5:37 ` Jarek Poplawski
2008-10-22 16:00 ` Patrick McHardy
2008-10-22 16:49 ` Jarek Poplawski
2008-10-22 17:32 ` Patrick McHardy
2008-10-22 17:53 ` [RFC] " Jarek Poplawski
2008-10-22 15:57 ` [PATCH] " Patrick McHardy
2008-10-22 16:00 ` Patrick McHardy
2008-10-17 20:45 ` [PATCH 0/6] Add qdisc->ops->peek() support Jarek Poplawski
2008-10-21 23:43 ` David Miller
2008-10-22 16:01 ` Patrick McHardy
2008-10-22 16:04 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48F735C7.6050808@trash.net \
--to=kaber@trash.net \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=jarkao2@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).