From: Patrick McHardy <kaber@trash.net>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: netfilter-devel@vger.kernel.org, netdev@vger.kernel.org,
containers@osdl.org
Subject: Re: [PATCH 1/7] netns ebtables: part 1
Date: Thu, 16 Oct 2008 15:18:36 +0200 [thread overview]
Message-ID: <48F73F2C.6030906@trash.net> (raw)
In-Reply-To: <20081015042509.GL24058@x200.localdomain>
Alexey Dobriyan wrote:
> On Wed, Oct 15, 2008 at 08:20:14AM +0400, Alexey Dobriyan wrote:
>> One needs to add ".netns_ok = 1" to igmp_protocol to test all of this
>> with ebtables() in netns.
>
> Contains 80-column violations, I forgot about damn script again :^)
Apart from the minor comment about patch 1 (and the 80 column violations
I didn't notice so far :)), these look good to me.
next prev parent reply other threads:[~2008-10-16 13:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-15 4:20 [PATCH 1/7] netns ebtables: part 1 Alexey Dobriyan
2008-10-15 4:25 ` Alexey Dobriyan
2008-10-16 13:18 ` Patrick McHardy [this message]
2008-10-16 13:12 ` Patrick McHardy
2008-10-16 19:39 ` Alexey Dobriyan
2008-10-17 11:57 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48F73F2C.6030906@trash.net \
--to=kaber@trash.net \
--cc=adobriyan@gmail.com \
--cc=containers@osdl.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).