From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pablo Neira Ayuso Subject: Re: [GIT]: Networking Date: Fri, 17 Oct 2008 14:34:40 +0200 Message-ID: <48F88660.7080204@netfilter.org> References: <20081015.163817.193700221.davem@davemloft.net> <20081017082138.GA23155@elte.hu> <48F87D3E.5020007@trash.net> <20081017120408.GA20030@elte.hu> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------000706050806010703080304" Cc: Patrick McHardy , David Miller , torvalds@linux-foundation.org, akpm@linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, benh@kernel.crashing.org To: Ingo Molnar Return-path: Received: from mail.us.es ([193.147.175.20]:36225 "EHLO us.es" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753606AbYJQMZB (ORCPT ); Fri, 17 Oct 2008 08:25:01 -0400 In-Reply-To: <20081017120408.GA20030@elte.hu> Sender: netdev-owner@vger.kernel.org List-ID: This is a multi-part message in MIME format. --------------000706050806010703080304 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Ingo Molnar wrote: > * Patrick McHardy wrote: > >>> net/netfilter/nf_conntrack_netlink.c:819: warning: ‘enum nf_nat_manip_type’ declared inside parameter list >>> net/netfilter/nf_conntrack_netlink.c:819: warning: its scope is only this definition or declaration, which is probably not what you want >>> net/netfilter/nf_conntrack_netlink.c:818: error: parameter 2 (‘manip’) has incomplete type >> Thanks Ingo. I just sent this patch to Benjamin Herrenschmidt >> for testing. > > build still fails with the attached config. This should fix it. I have slightly tested it here with your config. -- "Los honestos son inadaptados sociales" -- Les Luthiers --------------000706050806010703080304 Content-Type: text/plain; name="x" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="x" netfilter: ctnetlink: fix compilation without NAT support This patch fixes the compilation of ctnetlink when the NAT support is not enabled. /home/benh/kernels/linux-powerpc/net/netfilter/nf_conntrack_netlink.c:819: warning: enum nf_nat_manip_type\u2019 declared inside parameter list /home/benh/kernels/linux-powerpc/net/netfilter/nf_conntrack_netlink.c:819: warning: its scope is only this definition or declaration, which is probably not what you want Signed-off-by: Pablo Neira Ayuso Index: net-next-2.6/net/netfilter/nf_conntrack_netlink.c =================================================================== --- net-next-2.6.orig/net/netfilter/nf_conntrack_netlink.c 2008-10-17 14:15:26.000000000 +0200 +++ net-next-2.6/net/netfilter/nf_conntrack_netlink.c 2008-10-17 14:17:12.000000000 +0200 @@ -814,6 +814,7 @@ return err; } +#ifdef CONFIG_NF_NAT_NEEDED static int ctnetlink_parse_nat_setup(struct nf_conn *ct, enum nf_nat_manip_type manip, @@ -841,6 +842,7 @@ return parse_nat_setup(ct, manip, attr); } +#endif static int ctnetlink_change_status(struct nf_conn *ct, struct nlattr *cda[]) --------------000706050806010703080304--