* Re: [PATCH] AX88796: ax_probe() fix irq assignment
2008-10-21 5:44 [PATCH] AX88796: ax_probe() fix irq assignment roel kluin
@ 2008-10-21 5:15 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2008-10-21 5:15 UTC (permalink / raw)
To: roel kluin; +Cc: ben-linux, netdev
roel kluin wrote:
> dev->irq is unsigned
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> diff --git a/drivers/net/ax88796.c b/drivers/net/ax88796.c
> index 4207d6e..9a314d8 100644
> --- a/drivers/net/ax88796.c
> +++ b/drivers/net/ax88796.c
> @@ -838,12 +838,12 @@ static int ax_probe(struct platform_device *pdev)
>
> /* find the platform resources */
>
> - dev->irq = platform_get_irq(pdev, 0);
> - if (dev->irq < 0) {
> + ret = platform_get_irq(pdev, 0);
> + if (ret < 0) {
> dev_err(&pdev->dev, "no IRQ specified\n");
> - ret = -ENXIO;
> goto exit_mem;
> }
> + dev->irq = ret;
applied
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH] AX88796: ax_probe() fix irq assignment
@ 2008-10-21 5:44 roel kluin
2008-10-21 5:15 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: roel kluin @ 2008-10-21 5:44 UTC (permalink / raw)
To: ben-linux; +Cc: netdev
dev->irq is unsigned
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
diff --git a/drivers/net/ax88796.c b/drivers/net/ax88796.c
index 4207d6e..9a314d8 100644
--- a/drivers/net/ax88796.c
+++ b/drivers/net/ax88796.c
@@ -838,12 +838,12 @@ static int ax_probe(struct platform_device *pdev)
/* find the platform resources */
- dev->irq = platform_get_irq(pdev, 0);
- if (dev->irq < 0) {
+ ret = platform_get_irq(pdev, 0);
+ if (ret < 0) {
dev_err(&pdev->dev, "no IRQ specified\n");
- ret = -ENXIO;
goto exit_mem;
}
+ dev->irq = ret;
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
if (res == NULL) {
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-10-21 5:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-10-21 5:44 [PATCH] AX88796: ax_probe() fix irq assignment roel kluin
2008-10-21 5:15 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).