From: Jeff Garzik <jeff@garzik.org>
To: Brice Goglin <brice@myri.com>
Cc: Jeff Garzik <jgarzik@redhat.com>, netdev@vger.kernel.org
Subject: Re: [PATCH] myri10ge: disable NAPI on failure to setup the interface
Date: Tue, 21 Oct 2008 01:15:31 -0400 [thread overview]
Message-ID: <48FD6573.1080400@garzik.org> (raw)
In-Reply-To: <48FC7164.8040002@myri.com>
Brice Goglin wrote:
> Disable NAPI if a failure occurs when setting up the interface. Leaving
> it enabled could cause a BUG the next time an ifconfig up is issued.
>
> Signed-off-by: Brice Goglin <brice@myri.com>
>
> --- linux-2.6/drivers/net/myri10ge/myri10ge.c 2008-10-20 08:36:48.000000000 +0200
> +++ linux-tmp/drivers/net/myri10ge/myri10ge.c 2008-10-20 13:47:21.000000000 +0200
> @@ -75,7 +75,7 @@
> #include "myri10ge_mcp.h"
> #include "myri10ge_mcp_gen_header.h"
>
> -#define MYRI10GE_VERSION_STR "1.4.3-1.369"
> +#define MYRI10GE_VERSION_STR "1.4.3-1.371"
>
> MODULE_DESCRIPTION("Myricom 10G driver (10GbE)");
> MODULE_AUTHOR("Maintainer: help@myri.com");
> @@ -2497,6 +2497,10 @@ static int myri10ge_open(struct net_devi
> return 0;
>
> abort_with_rings:
> + while (slice) {
> + slice--;
> + napi_disable(&mgp->ss[slice].napi);
> + }
applied
prev parent reply other threads:[~2008-10-21 5:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-20 11:54 [PATCH] myri10ge: disable NAPI on failure to setup the interface Brice Goglin
2008-10-21 5:15 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48FD6573.1080400@garzik.org \
--to=jeff@garzik.org \
--cc=brice@myri.com \
--cc=jgarzik@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).