* [PATCH] myri10ge: disable NAPI on failure to setup the interface
@ 2008-10-20 11:54 Brice Goglin
2008-10-21 5:15 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Brice Goglin @ 2008-10-20 11:54 UTC (permalink / raw)
To: Jeff Garzik; +Cc: netdev
Disable NAPI if a failure occurs when setting up the interface. Leaving
it enabled could cause a BUG the next time an ifconfig up is issued.
Signed-off-by: Brice Goglin <brice@myri.com>
--- linux-2.6/drivers/net/myri10ge/myri10ge.c 2008-10-20 08:36:48.000000000 +0200
+++ linux-tmp/drivers/net/myri10ge/myri10ge.c 2008-10-20 13:47:21.000000000 +0200
@@ -75,7 +75,7 @@
#include "myri10ge_mcp.h"
#include "myri10ge_mcp_gen_header.h"
-#define MYRI10GE_VERSION_STR "1.4.3-1.369"
+#define MYRI10GE_VERSION_STR "1.4.3-1.371"
MODULE_DESCRIPTION("Myricom 10G driver (10GbE)");
MODULE_AUTHOR("Maintainer: help@myri.com");
@@ -2497,6 +2497,10 @@ static int myri10ge_open(struct net_devi
return 0;
abort_with_rings:
+ while (slice) {
+ slice--;
+ napi_disable(&mgp->ss[slice].napi);
+ }
for (i = 0; i < mgp->num_slices; i++)
myri10ge_free_rings(&mgp->ss[i]);
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] myri10ge: disable NAPI on failure to setup the interface
2008-10-20 11:54 [PATCH] myri10ge: disable NAPI on failure to setup the interface Brice Goglin
@ 2008-10-21 5:15 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2008-10-21 5:15 UTC (permalink / raw)
To: Brice Goglin; +Cc: Jeff Garzik, netdev
Brice Goglin wrote:
> Disable NAPI if a failure occurs when setting up the interface. Leaving
> it enabled could cause a BUG the next time an ifconfig up is issued.
>
> Signed-off-by: Brice Goglin <brice@myri.com>
>
> --- linux-2.6/drivers/net/myri10ge/myri10ge.c 2008-10-20 08:36:48.000000000 +0200
> +++ linux-tmp/drivers/net/myri10ge/myri10ge.c 2008-10-20 13:47:21.000000000 +0200
> @@ -75,7 +75,7 @@
> #include "myri10ge_mcp.h"
> #include "myri10ge_mcp_gen_header.h"
>
> -#define MYRI10GE_VERSION_STR "1.4.3-1.369"
> +#define MYRI10GE_VERSION_STR "1.4.3-1.371"
>
> MODULE_DESCRIPTION("Myricom 10G driver (10GbE)");
> MODULE_AUTHOR("Maintainer: help@myri.com");
> @@ -2497,6 +2497,10 @@ static int myri10ge_open(struct net_devi
> return 0;
>
> abort_with_rings:
> + while (slice) {
> + slice--;
> + napi_disable(&mgp->ss[slice].napi);
> + }
applied
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-10-21 5:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-10-20 11:54 [PATCH] myri10ge: disable NAPI on failure to setup the interface Brice Goglin
2008-10-21 5:15 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).