From: Eric Dumazet <dada1@cosmosbay.com>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: Jeff Garzik <jgarzik@pobox.com>, netdev@vger.kernel.org
Subject: Re: [PATCH] sky2: skb recycling
Date: Tue, 21 Oct 2008 07:54:18 +0200 [thread overview]
Message-ID: <48FD6E8A.6060304@cosmosbay.com> (raw)
In-Reply-To: <20081020190922.7dd6510a@extreme>
Stephen Hemminger a écrit :
> Add support for recycling tx buffers into receive buffers.
> This is experimental at this point.
>
I really like this skb recycling
For best performance, driver should perform TX completion before RX completion, so that
freshly added skb in recycle queue have a chance being reused right after. Apparently sky2
tx handling is finegrained (events posted by NIC)
But still, this mechanism also use more skbs per device, especially on dormant ones.
If your RX ring has 256 skb, then adding the recycle queue can adds 256 more skbs... One MB or event more...
Maybe we should flush the recycle queue, every 5 seconds or so, especially if device is dormant
(no RX on it, litle heartbeat TX)
next prev parent reply other threads:[~2008-10-21 5:54 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-21 2:09 [PATCH] sky2: skb recycling Stephen Hemminger
2008-10-21 5:18 ` David Miller
2008-10-21 19:59 ` Rick Jones
2008-10-21 20:15 ` Eric Dumazet
2008-10-21 20:38 ` Stephen Hemminger
2008-10-22 23:58 ` Rick Jones
2008-10-23 0:05 ` Stephen Hemminger
2008-10-23 0:17 ` Rick Jones
2008-10-21 5:54 ` Eric Dumazet [this message]
2008-10-21 8:25 ` Robert Olsson
2008-10-21 8:49 ` Terry
2008-10-21 12:17 ` Robert Olsson
2008-10-21 12:34 ` Terry
2008-10-21 12:42 ` Eric Dumazet
2008-10-21 13:04 ` Robert Olsson
2008-10-21 9:53 ` Eric Dumazet
2008-10-21 11:58 ` Robert Olsson
2008-10-23 5:28 ` David Miller
2008-10-21 15:09 ` Stephen Hemminger
2008-10-22 11:03 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48FD6E8A.6060304@cosmosbay.com \
--to=dada1@cosmosbay.com \
--cc=jgarzik@pobox.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).