From: Jarek Poplawski <jarkao2@gmail.com>
To: "Alex Villacís Lasso" <avillaci@ceibo.fiec.espol.edu.ec>
Cc: netdev@vger.kernel.org
Subject: Re: Regression: Recent networking (qdisc?) patches break irda_get_next_speed()
Date: Tue, 21 Oct 2008 21:37:37 +0200 [thread overview]
Message-ID: <48FE2F81.9060801@gmail.com> (raw)
In-Reply-To: <48FE1D52.6080903@ceibo.fiec.espol.edu.ec>
Alex Villacís Lasso wrote, On 10/21/2008 08:20 PM:
> A regression has been introduced in 2.6.27 in the networking code, which
> breaks the irda_get_next_speed() function used by some IrDA drivers,
> including ks959-sir, written by me. I have filed a bug at:
>
> http://bugzilla.kernel.org/show_bug.cgi?id=11795
>
> to keep track of this. I am still performing bisection to locate the
> exact commit that broke the code, but the bug involves an overwriting of
> the beginning of a structure with extraneous data that makes the
> LAP_MAGIC check fail. I have tried searching the netdev archives, but
> there is no mention at all of regressions caused by this code. Milan
> Plzik at irda-users mentions the same problem affecting pxaficp_ir, and
> mentions recent qdisc patches as possible culprits. Vasily Khoruzhick
> reported this bug at irda-users, and a quick hack (not a proper fix)
> proposed by him involves padding "struct irda_skb_cb" with 4 bytes at
> the beginning of the structure to move everything else past the buggy
> scribbling.
Looks like the patch below could fit to your description.
Jarek P.
commit 175f9c1bba9b825d22b142d183c9e175488b260c
Author: Jussi Kivilinna <jussi.kivilinna@mbnet.fi>
Date: Sun Jul 20 00:08:47 2008 -0700
net_sched: Add size table for qdiscs
Add size table functions for qdiscs and calculate packet size in
qdisc_enqueue().
Based on patch by Patrick McHardy
http://marc.info/?l=linux-netdev&m=115201979221729&w=2
Signed-off-by: Jussi Kivilinna <jussi.kivilinna@mbnet.fi>
Signed-off-by: David S. Miller <davem@davemloft.net>
next prev parent reply other threads:[~2008-10-21 19:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-21 18:20 Regression: Recent networking (qdisc?) patches break irda_get_next_speed() Alex Villacís Lasso
2008-10-21 19:37 ` Jarek Poplawski [this message]
2008-10-21 23:37 ` Alex Villacís Lasso
2008-10-21 23:41 ` David Miller
[not found] ` <20081021.164121.257737412.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2008-10-23 0:24 ` Alex Villacís Lasso
2008-10-23 22:13 ` Brandeburg, Jesse
2008-10-23 23:16 ` Stephen Hemminger
2008-10-24 0:21 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48FE2F81.9060801@gmail.com \
--to=jarkao2@gmail.com \
--cc=avillaci@ceibo.fiec.espol.edu.ec \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).