From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D96B8C169C4 for ; Wed, 30 Jan 2019 03:40:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A4BFA2184D for ; Wed, 30 Jan 2019 03:40:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BWXLG+Kd" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729989AbfA3Dko (ORCPT ); Tue, 29 Jan 2019 22:40:44 -0500 Received: from mail-ot1-f65.google.com ([209.85.210.65]:33347 "EHLO mail-ot1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727527AbfA3Dko (ORCPT ); Tue, 29 Jan 2019 22:40:44 -0500 Received: by mail-ot1-f65.google.com with SMTP id i20so19998693otl.0 for ; Tue, 29 Jan 2019 19:40:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=r3PfthaI2TMp5ZEb3CnvyS2HCrmWkG6c88jRbR1L40c=; b=BWXLG+Kdctc25YkCFW3DMNlM2aVITAkAGyxqZCUyNd10JQozus8/ZrwptVnZOV2sZ4 J/OmsiRhhqZF4YXMK/JNcgtg9l5rVaf7Q+AGJwZOTv0djkt98joI4YQl6LsVWR+WFwoQ wt0RFYmK+Hkgj+pgEXh7taDlbQJy1dt4xXCl0pUWiifqj0tfXWoufOelsG3gxuBBiQQl A0CvNhtzf4HJC8Zy1OFmCNHr9Z+aFmK01MinnS3eK3lA3B4PbHxTmxmN4IKS1CEhsU6w YdscjTnT1QroGvnzr+x9+xER13r0c3j+L/yn8y8TUcvy0UyzCA4MP0GZfZHeBD2BBtg6 PMkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=r3PfthaI2TMp5ZEb3CnvyS2HCrmWkG6c88jRbR1L40c=; b=VkQDaObIXsPKUbsXgGHWfuvlACPvkklXnjXtRs2g/d8izFt+cxugskcEFzCqa1RUOQ rCcyqQIOgTAQSVxqEo7n8ojfPm8LYBYPVHy5yhYufax4YHyHbkCuFMRXz3+lZvDCE8ej HOGQ5t9BKNBgYfYjiX0aKIzcTjp3DeuPGTBrtvdbJ75yAV1SR4rvUq1W8gG3cLRjQ0AJ PCh35F2KivOK+3A4tRzFM8chIpQTBpv3CAq1kfRDczbciO68xHCA3tLmRckuBRf9yYUX t/FKsBHwTmgr0EPlQZtUWWStiEhJTXCEUN0vLi90hA1BbsyyklyurmgXUIttXapkluvM FhxA== X-Gm-Message-State: AJcUukdn3pOnhl244dn+YlHAXBN7RcxnnAzKDzlKTpRqLdGsXHtum2Au bRaz+jo+ladtu6vrB6iyz3F15K8s X-Google-Smtp-Source: ALg8bN5vbQNoYWvaRa9mc01DA89nkCD+kJ37RvV/znX9QhaLHu0xNqEzd1FBLYjt8cxMlgCQysXhKA== X-Received: by 2002:a9d:1f3:: with SMTP id e106mr20569171ote.369.1548819643197; Tue, 29 Jan 2019 19:40:43 -0800 (PST) Received: from [10.0.2.15] (ip68-228-73-187.oc.oc.cox.net. [68.228.73.187]) by smtp.gmail.com with ESMTPSA id z15sm155743oib.23.2019.01.29.19.40.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 29 Jan 2019 19:40:42 -0800 (PST) Subject: Re: [PATCHv4 1/3] net: ethernet: mediatek: support MT7621 SoC ethernet hardware To: gerg@kernel.org, sean.wang@mediatek.com, linux-mediatek@lists.infradead.org, bjorn@mork.no, andrew@lunn.ch, vivien.didelot@savoirfairelinux.com, netdev@vger.kernel.org Cc: rene@vdorst.com, john@phrozen.org, neil@brown.name References: <20190130012406.28271-1-gerg@kernel.org> <20190130012406.28271-2-gerg@kernel.org> From: Florian Fainelli Message-ID: <48bb34ce-9bb0-2dc1-0e17-55e000a23114@gmail.com> Date: Tue, 29 Jan 2019 19:40:39 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20190130012406.28271-2-gerg@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 1/29/19 5:24 PM, gerg@kernel.org wrote: > From: Bjørn Mork > > The Mediatek MT7621 SoC contains the same ethernet hardware module as > used on a number of other MediaTek SoC parts. There are some minor > differences to deal with but we can use the same driver to support > them all. > > This patch is based on work by Bjørn Mork , and his > original patch is at: > > https://github.com/bmork/LEDE/commit/3293bc63f5461ca1eb0bbc4ed90145335e7e3404 > > There is an additional compatible devicetree type added, and the primary > change to the code required is to support a single interrupt (for both > RX and TX interrupts). > > Signed-off-by: Bjørn Mork > [gerg@kernel.org: rebase to mainline and irq handler fix] > Signed-off-by: Greg Ungerer Reviewed-by: Florian Fainelli > --- > drivers/net/ethernet/mediatek/Kconfig | 2 +- > drivers/net/ethernet/mediatek/mtk_eth_soc.c | 48 ++++++++++++++++++--- > drivers/net/ethernet/mediatek/mtk_eth_soc.h | 4 ++ > 3 files changed, 46 insertions(+), 8 deletions(-) > > v2: first in series for this change > v3: rebase onto 5.0-rc3 > v4: rebase onto 5.0-rc4 > > diff --git a/drivers/net/ethernet/mediatek/Kconfig b/drivers/net/ethernet/mediatek/Kconfig > index f9149d2a4694..43656f961891 100644 > --- a/drivers/net/ethernet/mediatek/Kconfig > +++ b/drivers/net/ethernet/mediatek/Kconfig > @@ -1,6 +1,6 @@ > config NET_VENDOR_MEDIATEK > bool "MediaTek ethernet driver" > - depends on ARCH_MEDIATEK > + depends on ARCH_MEDIATEK || SOC_MT7621 Would be nice to add COMPILE_TEST there as well at some point so someone can easily build test changes to the driver. -- Florian