From: Florian Fainelli <f.fainelli@gmail.com>
To: Christian Marangi <ansuelsmth@gmail.com>,
Andrew Lunn <andrew@lunn.ch>, Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Atin Bainada <hi@atinb.me>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [net-next PATCH 2/3] net: dsa: qca8k: make learning configurable and keep off if standalone
Date: Wed, 26 Jul 2023 15:22:18 -0700 [thread overview]
Message-ID: <48dad8c9-c61c-8d08-de57-a1255dfa8228@gmail.com> (raw)
In-Reply-To: <20230724033058.16795-2-ansuelsmth@gmail.com>
On 7/23/23 20:30, Christian Marangi wrote:
> Address learning should initially be turned off by the driver for port
> operation in standalone mode, then the DSA core handles changes to it
> via ds->ops->port_bridge_flags().
>
> Currently this is not the case for qca8k where learning is enabled
> unconditionally in qca8k_setup for every user port.
>
> Handle ports configured in standalone mode by making the learning
> configurable and not enabling it by default.
>
> Implement .port_pre_bridge_flags and .port_bridge_flags dsa ops to
> enable learning for bridge that request it and tweak
> .port_stp_state_set to correctly disable learning when port is
> configured in standalone mode.
>
> Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
With the feedback from Vladimir being addressed:
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
--
Florian
next prev parent reply other threads:[~2023-07-26 22:22 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-24 3:30 [net-next PATCH 1/3] net: dsa: tag_qca: return early if dev is not found Christian Marangi
2023-07-24 3:30 ` [net-next PATCH 2/3] net: dsa: qca8k: make learning configurable and keep off if standalone Christian Marangi
2023-07-26 8:19 ` Simon Horman
2023-07-26 12:14 ` Vladimir Oltean
2023-07-26 13:15 ` Simon Horman
2023-07-26 12:12 ` Vladimir Oltean
2023-07-27 19:05 ` Christian Marangi
2023-07-26 22:22 ` Florian Fainelli [this message]
2023-07-24 3:30 ` [net-next PATCH 3/3] net: dsa: qca8k: limit user ports access to the first CPU port on setup Christian Marangi
2023-07-26 8:19 ` Simon Horman
2023-07-26 13:18 ` Vladimir Oltean
2023-07-27 19:10 ` Christian Marangi
2023-07-27 21:14 ` Vladimir Oltean
2023-07-26 22:21 ` Florian Fainelli
2023-07-27 21:16 ` Vladimir Oltean
2023-07-26 8:17 ` [net-next PATCH 1/3] net: dsa: tag_qca: return early if dev is not found Simon Horman
2023-07-26 12:06 ` Vladimir Oltean
2023-07-26 22:19 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48dad8c9-c61c-8d08-de57-a1255dfa8228@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=ansuelsmth@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hi@atinb.me \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).