From: Saeed Mahameed <saeed@kernel.org>
To: Zhu Yanjun <yanjunz@nvidia.com>,
leon@kernel.org, kuba@kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 1/1] net/mlx5e: remove unnecessary memset
Date: Mon, 09 Nov 2020 22:35:48 -0800 [thread overview]
Message-ID: <48de4584fecb4dd9c2db3a1de1a754d8a0e079c7.camel@kernel.org> (raw)
In-Reply-To: <1604721272-23314-1-git-send-email-yanjunz@nvidia.com>
On Sat, 2020-11-07 at 11:54 +0800, Zhu Yanjun wrote:
> Since kvzalloc will initialize the allocated memory, it is not
> necessary to initialize it once again.
>
> Fixes: 11b717d61526 ("net/mlx5: E-Switch, Get reg_c0 value on CQE")
> Signed-off-by: Zhu Yanjun <yanjunz@nvidia.com>
> ---
> .../ethernet/mellanox/mlx5/core/eswitch_offloads.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git
> a/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c
> b/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c
> index 1bcf260..35c5629 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c
> @@ -1528,7 +1528,6 @@ static int esw_create_restore_table(struct
> mlx5_eswitch *esw)
> goto out_free;
> }
>
> - memset(flow_group_in, 0, inlen);
> match_criteria = MLX5_ADDR_OF(create_flow_group_in,
> flow_group_in,
> match_criteria);
> misc = MLX5_ADDR_OF(fte_match_param, match_criteria,
applied to net-next-mlx5,
Thank you !
prev parent reply other threads:[~2020-11-10 6:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-07 3:54 [PATCH 1/1] net/mlx5e: remove unnecessary memset Zhu Yanjun
2020-11-10 6:35 ` Saeed Mahameed [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48de4584fecb4dd9c2db3a1de1a754d8a0e079c7.camel@kernel.org \
--to=saeed@kernel.org \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yanjunz@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).