From: Jesus Sanchez-Palencia <jesus.sanchez-palencia@intel.com>
To: Alexander Duyck <alexander.duyck@gmail.com>,
"Chopra, Manish" <Manish.Chopra@cavium.com>
Cc: Stephen Hemminger <stephen@networkplumber.org>,
David Miller <davem@davemloft.net>, Jiri Pirko <jiri@resnulli.us>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: tc mqprio offload command error
Date: Mon, 16 Jul 2018 10:57:38 -0700 [thread overview]
Message-ID: <48e85e30-ab4c-fa07-463e-d10ac14327d3@intel.com> (raw)
In-Reply-To: <CAKgT0UfdckbsMDM3-uF4gOCumvDmFx6eWFuJx9_oKKUyEVApCA@mail.gmail.com>
Hi,
On 07/16/2018 10:20 AM, Alexander Duyck wrote:
> On Sun, Jul 15, 2018 at 6:30 PM, Chopra, Manish
> <Manish.Chopra@cavium.com> wrote:
>> Hello Folks,
>>
>> I am trying to set below command to try mqprio offload on 4.18 kernel. It is throwing the flowing error.
>>
>> # tc qdisc add dev eth0 root mqprio num_tc 2 map 1 1 1 1 0 0 0 0
>> RTNETLINK answers: Numerical result out of range
>>
>> I can't really make out what's wrong with the above command, since this works fine with other OS kernels.
>> Any thoughts if it is something broken on upstream kernel ?
>>
>> Thanks,
>> Manish
>
> You might need to specify the traffic class for the 8 remaining
> priorities. The full map size is 16 entries, not just 8. The default
> value for the last 4 mapping entries is TC 3 which would be out of
> range if you only have 2 TCs specified.
In addition to that, you might hit the same bug we brought up [1] a while ago.
If that is the case, a fix was just proposed here [2]. Note that other qdiscs
might be broken as well, but we could only spot the issue with mqprio and netem
so far.
[1] https://patchwork.ozlabs.org/patch/867860/#1893405
[2] https://patchwork.ozlabs.org/patch/944565/
Regards,
Jesus
>
> - Alex
>
next prev parent reply other threads:[~2018-07-16 18:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-16 1:30 tc mqprio offload command error Chopra, Manish
2018-07-16 17:20 ` Alexander Duyck
2018-07-16 17:57 ` Jesus Sanchez-Palencia [this message]
2018-07-16 18:46 ` Chopra, Manish
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48e85e30-ab4c-fa07-463e-d10ac14327d3@intel.com \
--to=jesus.sanchez-palencia@intel.com \
--cc=Manish.Chopra@cavium.com \
--cc=alexander.duyck@gmail.com \
--cc=davem@davemloft.net \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).