From: "Chris Friesen" <cfriesen@nortel.com>
To: David Miller <davem@davemloft.net>
Cc: jesse.brandeburg@intel.com, linuxppc-dev@ozlabs.org,
netdev@vger.kernel.org, romieu@fr.zoreil.com
Subject: Re: [BUG] oops in net_rx_action on 64-bit powerpc
Date: Fri, 24 Oct 2008 23:42:48 -0600 [thread overview]
Message-ID: <4902B1D8.8070800@nortel.com> (raw)
In-Reply-To: <20081024.164128.113131091.davem@davemloft.net>
David Miller wrote:
> From: "Chris Friesen" <cfriesen@nortel.com>
> Date: Fri, 24 Oct 2008 17:39:00 -0600
>
>> So...it would appear that the NAPI code is somehow buggy, and
>> 6ba33ac should probably be reverted until the problem is found and
>> fixed.
>
> No I think the problem is simple enough that someone should study the
> ->poll() routine quickly and audit it's return values.
Assuming that amd8111e_rx_poll() is the proper routine, there is only one exit
point, and it returns "num_rx_pkt". This variable is initialized to zero and
increments for each packet sent up the stack.
Chris
next prev parent reply other threads:[~2008-10-25 5:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-23 19:59 [BUG] oops in net_rx_action on 64-bit powerpc Chris Friesen
2008-10-23 21:50 ` Brandeburg, Jesse
2008-10-24 0:16 ` David Miller
2008-10-24 23:39 ` Chris Friesen
2008-10-24 23:41 ` David Miller
2008-10-25 5:42 ` Chris Friesen [this message]
2008-10-25 7:17 ` David Miller
2008-10-28 0:13 ` Chris Friesen
2008-10-28 22:51 ` David Miller
2008-10-28 22:59 ` Chris Friesen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4902B1D8.8070800@nortel.com \
--to=cfriesen@nortel.com \
--cc=davem@davemloft.net \
--cc=jesse.brandeburg@intel.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).