From: Jeff Garzik <jgarzik@pobox.com>
To: Francois Romieu <romieu@fr.zoreil.com>
Cc: "Linus Torvalds" <torvalds@linux-foundation.org>,
"David Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
"Alistair John Strachan" <alistair@devzero.co.uk>,
"Ivan Vecera" <ivecera@redhat.com>,
"Chuck Ebbert" <cebbert@redhat.com>,
"Krzysztof Halasa" <khc@pm.waw.pl>,
"Petr Vandrovec" <petr@vandrovec.name>,
"Plamen Petrov" <pvp-lsts@fs.ru.acad.bg>,
"Ilpo Järvinen" <ilpo.jarvinen@helsinki.fi>,
"\"J.A. Magallón\"" <jamagallon@ono.com>,
"Jiri Slaby" <jirislaby@gmail.com>,
"Simon Arlott" <simon@fire.lp0.eu>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Edward Hsu" <edward_hsu@realtek.com.tw>
Subject: Re: [PATCH 1/1] r8169: revert "read MAC address from EEPROM on init"
Date: Sun, 26 Oct 2008 12:26:27 -0400 [thread overview]
Message-ID: <49049A33.2080203@pobox.com> (raw)
In-Reply-To: <20081026160249.GA25443@electric-eye.fr.zoreil.com>
Francois Romieu wrote:
> This reverts commit 7bf6bf4803df1adc927f585168d2135fb019c698.
>
> The code has both a short existence and an increasing track
> of failures despite some work to amend it for -rc1. It is not
> just a matter of reading the eeprom: sometimes the eeprom is
> read correctly, then the mac address is not written correctly
> back into the mac registers.
>
> Some chipsets seem to work reliably but it is not clear at
> this point if the code can simply be made to work on a
> per-chipset basis and post -rc1 is not the place where I want
> to experiment these things.
>
> Signed-off-by: Francois Romieu <romieu@fr.zoreil.com>
Acked-by: Jeff Garzik <jgarzik@redhat.com>
I'll send upstream if Linus doesn't pick it up shortly...
next prev parent reply other threads:[~2008-10-26 16:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-26 16:02 [PATCH 1/1] r8169: revert "read MAC address from EEPROM on init" Francois Romieu
2008-10-26 16:26 ` Jeff Garzik [this message]
[not found] ` <m3wsfvhx8c.fsf@maximus.localdomain>
2008-10-26 22:22 ` Francois Romieu
2008-10-27 14:49 ` Krzysztof Halasa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49049A33.2080203@pobox.com \
--to=jgarzik@pobox.com \
--cc=akpm@linux-foundation.org \
--cc=alistair@devzero.co.uk \
--cc=cebbert@redhat.com \
--cc=davem@davemloft.net \
--cc=edward_hsu@realtek.com.tw \
--cc=ilpo.jarvinen@helsinki.fi \
--cc=ivecera@redhat.com \
--cc=jamagallon@ono.com \
--cc=jirislaby@gmail.com \
--cc=khc@pm.waw.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=petr@vandrovec.name \
--cc=pvp-lsts@fs.ru.acad.bg \
--cc=romieu@fr.zoreil.com \
--cc=simon@fire.lp0.eu \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).