* [PATCH] ibm_newemac: Fix typo in flow control config option
@ 2008-10-24 13:53 Josh Boyer
2008-10-27 18:52 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Josh Boyer @ 2008-10-24 13:53 UTC (permalink / raw)
To: benh; +Cc: hch, linuxppc-dev, netdev
The recent build fix for ibm_newemac has a typo in the config
option #ifdef used for disabling flow control. This corrects
it to the proper Kconfig option name.
Reported-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Josh Boyer <jwboyer@linux.vnet.ibm.com>
---
diff --git a/drivers/net/ibm_newemac/core.c b/drivers/net/ibm_newemac/core.c
index 2ee2622..901212a 100644
--- a/drivers/net/ibm_newemac/core.c
+++ b/drivers/net/ibm_newemac/core.c
@@ -2605,7 +2605,7 @@ static int __devinit emac_init_config(struct emac_instance *dev)
of_device_is_compatible(np, "ibm,emac-440gr"))
dev->features |= EMAC_FTR_440EP_PHY_CLK_FIX;
if (of_device_is_compatible(np, "ibm,emac-405ez")) {
-#ifdef CONFIG_IBM_NEW_EMAC_NO_FLOW_CONTROL
+#ifdef CONFIG_IBM_NEW_EMAC_NO_FLOW_CTRL
dev->features |= EMAC_FTR_NO_FLOW_CONTROL_40x;
#else
printk(KERN_ERR "%s: Flow control not disabled!\n",
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ibm_newemac: Fix typo in flow control config option
2008-10-24 13:53 [PATCH] ibm_newemac: Fix typo in flow control config option Josh Boyer
@ 2008-10-27 18:52 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2008-10-27 18:52 UTC (permalink / raw)
To: Josh Boyer; +Cc: benh, hch, linuxppc-dev, netdev
Josh Boyer wrote:
> The recent build fix for ibm_newemac has a typo in the config
> option #ifdef used for disabling flow control. This corrects
> it to the proper Kconfig option name.
>
> Reported-by: Christoph Hellwig <hch@lst.de>
> Signed-off-by: Josh Boyer <jwboyer@linux.vnet.ibm.com>
>
> ---
>
> diff --git a/drivers/net/ibm_newemac/core.c b/drivers/net/ibm_newemac/core.c
> index 2ee2622..901212a 100644
> --- a/drivers/net/ibm_newemac/core.c
> +++ b/drivers/net/ibm_newemac/core.c
> @@ -2605,7 +2605,7 @@ static int __devinit emac_init_config(struct emac_instance *dev)
> of_device_is_compatible(np, "ibm,emac-440gr"))
> dev->features |= EMAC_FTR_440EP_PHY_CLK_FIX;
> if (of_device_is_compatible(np, "ibm,emac-405ez")) {
> -#ifdef CONFIG_IBM_NEW_EMAC_NO_FLOW_CONTROL
> +#ifdef CONFIG_IBM_NEW_EMAC_NO_FLOW_CTRL
> dev->features |= EMAC_FTR_NO_FLOW_CONTROL_40x;
> #else
> printk(KERN_ERR "%s: Flow control not disabled!\n",
applied
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-10-27 18:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-10-24 13:53 [PATCH] ibm_newemac: Fix typo in flow control config option Josh Boyer
2008-10-27 18:52 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).