From: Patrick McHardy <kaber@trash.net>
To: "J. K. Cliburn" <jcliburn@gmail.com>
Cc: Jarek Poplawski <jarkao2@gmail.com>,
netdev@vger.kernel.org, Ramon Casellas <ramon.casellas@cttc.es>
Subject: Re: atl1 warn_on_slowpath help
Date: Wed, 29 Oct 2008 13:54:28 +0100 [thread overview]
Message-ID: <49085D04.1060009@trash.net> (raw)
In-Reply-To: <3400f2f60810290551y39c61e0aj90ca1222b339798c@mail.gmail.com>
J. K. Cliburn wrote:
> [adding bug reporter to cc list]
>
> On Wed, Oct 29, 2008 at 5:17 AM, Patrick McHardy <kaber@trash.net> wrote:
>> This is the best I could come up with, short of simply restoring
>> the old behaviour for non-polling drivers.
>>
>> The __vlan_hwaccel_rx function only does the device lookup and
>> stores it in the cb. The remaining processing is done in a new
>> function that is invoked by netif_receive_skb(), in the proper
>> context. Unfortunatly this needs vlan-specific handling in
>> netif_receive_skb().
>>
>
> Thanks Jarek and Patrick.
>
> Ramon,
>
> Can you please try the attached patch from Patrick and see if it fixes
> your kernel warning?
Just to make sure we don't run into testing mistakes -
the ethernet device needs to have tcpdump or something
similar running to trigger this warning.
next prev parent reply other threads:[~2008-10-29 12:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-29 0:08 atl1 warn_on_slowpath help Jay Cliburn
2008-10-29 7:15 ` Jarek Poplawski
2008-10-29 8:12 ` Patrick McHardy
2008-10-29 10:17 ` Patrick McHardy
2008-10-29 12:51 ` J. K. Cliburn
2008-10-29 12:54 ` Patrick McHardy [this message]
2008-10-29 14:15 ` Ramon Casellas
2008-10-29 16:47 ` Patrick McHardy
2008-10-29 13:03 ` Jarek Poplawski
2008-10-29 13:09 ` Patrick McHardy
2008-10-29 13:22 ` Jarek Poplawski
2008-10-29 13:26 ` Patrick McHardy
2008-10-29 14:04 ` Jarek Poplawski
2008-10-29 16:40 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49085D04.1060009@trash.net \
--to=kaber@trash.net \
--cc=jarkao2@gmail.com \
--cc=jcliburn@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=ramon.casellas@cttc.es \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).