From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Sealey Subject: Re: [PATCH RFC v2] net: add PCINet driver Date: Wed, 29 Oct 2008 16:43:46 -0500 Message-ID: <4908D912.8010003@genesi-usa.com> References: <20081029202027.GH12879@ovro.caltech.edu> <20081029132506.55b93555@extreme> <20081029205002.GI12879@ovro.caltech.edu> <4908CD96.300@freescale.com> <20081029211312.GJ12879@ovro.caltech.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit To: Scott Wood , Stephen Hemminger , netdev@vger.kernel.org, linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org Return-path: Received: from qw-out-2122.google.com ([74.125.92.24]:27141 "EHLO qw-out-2122.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753852AbYJ2Vns (ORCPT ); Wed, 29 Oct 2008 17:43:48 -0400 Received: by qw-out-2122.google.com with SMTP id 3so140525qwe.37 for ; Wed, 29 Oct 2008 14:43:47 -0700 (PDT) In-Reply-To: <20081029211312.GJ12879@ovro.caltech.edu> Sender: netdev-owner@vger.kernel.org List-ID: Ira Snyder wrote: > > I'll go ahead change the typedef to a struct. Hopefully some of the > other inspiration I took wasn't too bad. I'm totally open to suggestions > on improvements for this driver. Not a suggestion for improvement, but I have to say this is by far the single coolest thing I have EVER seen submitted to mainline :) -- Matt Sealey Genesi, Manager, Developer Relations