* [RESEND][PATCH 2.6.28] myri10ge: fix stop/go mmio ordering
@ 2008-10-30 7:59 Brice Goglin
2008-10-31 4:49 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Brice Goglin @ 2008-10-30 7:59 UTC (permalink / raw)
To: Jeff Garzik; +Cc: netdev
Use mmiowb() to ensure "stop" and "go" commands are sent in order on ia64.
Signed-off-by: Brice Goglin <brice@myri.com>
--- linux-git/drivers/net/myri10ge/myri10ge.c 2008-10-30 08:15:37.000000000 +0100
+++ linux-tmp/drivers/net/myri10ge/myri10ge.c 2008-10-30 08:17:54.000000000 +0100
@@ -75,7 +75,7 @@
#include "myri10ge_mcp.h"
#include "myri10ge_mcp_gen_header.h"
-#define MYRI10GE_VERSION_STR "1.4.3-1.371"
+#define MYRI10GE_VERSION_STR "1.4.3-1.375"
MODULE_DESCRIPTION("Myricom 10G driver (10GbE)");
MODULE_AUTHOR("Maintainer: help@myri.com");
@@ -1393,6 +1393,7 @@
if (tx->req == tx->done) {
tx->queue_active = 0;
put_be32(htonl(1), tx->send_stop);
+ mmiowb();
}
__netif_tx_unlock(dev_queue);
}
@@ -2864,6 +2865,7 @@
if ((mgp->dev->real_num_tx_queues > 1) && tx->queue_active == 0) {
tx->queue_active = 1;
put_be32(htonl(1), tx->send_go);
+ mmiowb();
}
tx->pkt_start++;
if ((avail - count) < MXGEFW_MAX_SEND_DESC) {
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [RESEND][PATCH 2.6.28] myri10ge: fix stop/go mmio ordering
2008-10-30 7:59 [RESEND][PATCH 2.6.28] myri10ge: fix stop/go mmio ordering Brice Goglin
@ 2008-10-31 4:49 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2008-10-31 4:49 UTC (permalink / raw)
To: Brice Goglin; +Cc: netdev
Brice Goglin wrote:
> Use mmiowb() to ensure "stop" and "go" commands are sent in order on ia64.
>
> Signed-off-by: Brice Goglin <brice@myri.com>
>
> --- linux-git/drivers/net/myri10ge/myri10ge.c 2008-10-30 08:15:37.000000000 +0100
> +++ linux-tmp/drivers/net/myri10ge/myri10ge.c 2008-10-30 08:17:54.000000000 +0100
> @@ -75,7 +75,7 @@
> #include "myri10ge_mcp.h"
> #include "myri10ge_mcp_gen_header.h"
>
> -#define MYRI10GE_VERSION_STR "1.4.3-1.371"
> +#define MYRI10GE_VERSION_STR "1.4.3-1.375"
>
> MODULE_DESCRIPTION("Myricom 10G driver (10GbE)");
> MODULE_AUTHOR("Maintainer: help@myri.com");
> @@ -1393,6 +1393,7 @@
> if (tx->req == tx->done) {
> tx->queue_active = 0;
> put_be32(htonl(1), tx->send_stop);
> + mmiowb();
> }
> __netif_tx_unlock(dev_queue);
> }
> @@ -2864,6 +2865,7 @@
> if ((mgp->dev->real_num_tx_queues > 1) && tx->queue_active == 0) {
> tx->queue_active = 1;
> put_be32(htonl(1), tx->send_go);
> + mmiowb();
> }
> tx->pkt_start++;
> if ((avail - count) < MXGEFW_MAX_SEND_DESC) {
>
applied
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-10-31 4:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-10-30 7:59 [RESEND][PATCH 2.6.28] myri10ge: fix stop/go mmio ordering Brice Goglin
2008-10-31 4:49 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).