From: Patrick McHardy <kaber@trash.net>
To: Changli Gao <xiaosuo@gmail.com>
Cc: Jarek Poplawski <jarkao2@gmail.com>, netdev@vger.kernel.org
Subject: Re: [PATCH] HTB updates class's bstats in one place
Date: Thu, 30 Oct 2008 10:21:25 +0100 [thread overview]
Message-ID: <49097C95.2040806@trash.net> (raw)
In-Reply-To: <412e6f7f0810300211v53872b1bid2f9c8a1d89cde82@mail.gmail.com>
Changli Gao wrote:
> On Thu, Oct 30, 2008 at 3:11 PM, Patrick McHardy <kaber@trash.net> wrote:
>> Independant of this statistics bug, according to your description
>> you want to measure departure rates (otherwise the measured rates
>> can't really be compared to the limit) and the current counters are
>> not really suitable for this since they count arriving packets.
>> So the only way to properly do this is to add seperate counters that
>> account for departing packets. I think this would be a good addition
>> since we've always been advocating to do this stuff in userspace,
>> but it would need some thought on how to minimize the impact for
>> people not needing it.
>>
>>
> In fact, only the counters of the leaf classes represent arriving
> rates, but the others represent departing rates. Is it right? Or does
> it need to be fixed?
Its not correct, but I wouldn't fix it at this time unless you can
suggest a good way that doesn't require to walk the entire hierarchy
during ->enqueue() just for the class counters.
prev parent reply other threads:[~2008-10-30 9:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-29 8:54 [PATCH] HTB updates class's bstats in one place Changli Gao
2008-10-29 9:01 ` Patrick McHardy
2008-10-29 9:09 ` Changli Gao
2008-10-29 9:19 ` Patrick McHardy
2008-10-29 10:23 ` Jarek Poplawski
2008-10-29 10:33 ` Patrick McHardy
2008-10-29 18:22 ` David Miller
2008-10-30 1:03 ` Changli Gao
2008-10-30 7:11 ` Patrick McHardy
2008-10-30 9:11 ` Changli Gao
2008-10-30 9:21 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49097C95.2040806@trash.net \
--to=kaber@trash.net \
--cc=jarkao2@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=xiaosuo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).