* [patch 2.6.28-rc2] at91_ether: request/free GPIO for PHY interrupt
@ 2008-10-27 21:11 David Brownell
2008-10-31 4:48 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: David Brownell @ 2008-10-27 21:11 UTC (permalink / raw)
To: netdev; +Cc: Andrew Victor, Jeff Garzik
From: David Brownell <dbrownell@users.sourceforge.net>
When the at91_ether driver is using a GPIO for its PHY interrupt,
be sure to request (and later, if needed, free) that GPIO.
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
---
drivers/net/arm/at91_ether.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
--- a/drivers/net/arm/at91_ether.c
+++ b/drivers/net/arm/at91_ether.c
@@ -1080,7 +1080,8 @@ static int __init at91ether_setup(unsign
init_timer(&lp->check_timer);
lp->check_timer.data = (unsigned long)dev;
lp->check_timer.function = at91ether_check_link;
- }
+ } else if (lp->board_data.phy_irq_pin >= 32)
+ gpio_request(lp->board_data.phy_irq_pin, "ethernet_phy");
/* Display ethernet banner */
printk(KERN_INFO "%s: AT91 ethernet at 0x%08x int=%d %s%s (%s)\n",
@@ -1167,6 +1168,9 @@ static int __devexit at91ether_remove(st
struct net_device *dev = platform_get_drvdata(pdev);
struct at91_private *lp = netdev_priv(dev);
+ if (lp->board_data.phy_irq_pin >= 32)
+ gpio_free(lp->board_data.phy_irq_pin);
+
unregister_netdev(dev);
free_irq(dev->irq, dev);
dma_free_coherent(NULL, sizeof(struct recv_desc_bufs), lp->dlist, (dma_addr_t)lp->dlist_phys);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [patch 2.6.28-rc2] at91_ether: request/free GPIO for PHY interrupt
2008-10-27 21:11 [patch 2.6.28-rc2] at91_ether: request/free GPIO for PHY interrupt David Brownell
@ 2008-10-31 4:48 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2008-10-31 4:48 UTC (permalink / raw)
To: David Brownell; +Cc: netdev, Andrew Victor
David Brownell wrote:
> From: David Brownell <dbrownell@users.sourceforge.net>
>
> When the at91_ether driver is using a GPIO for its PHY interrupt,
> be sure to request (and later, if needed, free) that GPIO.
>
> Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
> ---
> drivers/net/arm/at91_ether.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
applied
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-10-31 4:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-10-27 21:11 [patch 2.6.28-rc2] at91_ether: request/free GPIO for PHY interrupt David Brownell
2008-10-31 4:48 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).