From: Jeff Garzik <jeff@garzik.org>
To: Brice Goglin <brice@myri.com>
Cc: netdev@vger.kernel.org
Subject: Re: [RESEND][PATCH 2.6.28] myri10ge: fix stop/go mmio ordering
Date: Fri, 31 Oct 2008 00:49:09 -0400 [thread overview]
Message-ID: <490A8E45.909@garzik.org> (raw)
In-Reply-To: <49096965.20905@myri.com>
Brice Goglin wrote:
> Use mmiowb() to ensure "stop" and "go" commands are sent in order on ia64.
>
> Signed-off-by: Brice Goglin <brice@myri.com>
>
> --- linux-git/drivers/net/myri10ge/myri10ge.c 2008-10-30 08:15:37.000000000 +0100
> +++ linux-tmp/drivers/net/myri10ge/myri10ge.c 2008-10-30 08:17:54.000000000 +0100
> @@ -75,7 +75,7 @@
> #include "myri10ge_mcp.h"
> #include "myri10ge_mcp_gen_header.h"
>
> -#define MYRI10GE_VERSION_STR "1.4.3-1.371"
> +#define MYRI10GE_VERSION_STR "1.4.3-1.375"
>
> MODULE_DESCRIPTION("Myricom 10G driver (10GbE)");
> MODULE_AUTHOR("Maintainer: help@myri.com");
> @@ -1393,6 +1393,7 @@
> if (tx->req == tx->done) {
> tx->queue_active = 0;
> put_be32(htonl(1), tx->send_stop);
> + mmiowb();
> }
> __netif_tx_unlock(dev_queue);
> }
> @@ -2864,6 +2865,7 @@
> if ((mgp->dev->real_num_tx_queues > 1) && tx->queue_active == 0) {
> tx->queue_active = 1;
> put_be32(htonl(1), tx->send_go);
> + mmiowb();
> }
> tx->pkt_start++;
> if ((avail - count) < MXGEFW_MAX_SEND_DESC) {
>
applied
prev parent reply other threads:[~2008-10-31 4:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-30 7:59 [RESEND][PATCH 2.6.28] myri10ge: fix stop/go mmio ordering Brice Goglin
2008-10-31 4:49 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=490A8E45.909@garzik.org \
--to=jeff@garzik.org \
--cc=brice@myri.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).