From: Jeff Garzik <jgarzik@pobox.com>
To: Jay Vosburgh <fubar@us.ibm.com>
Cc: netdev@vger.kernel.org, David Miller <davem@davemloft.net>
Subject: Re: [PATCH 1/3] bonding: fix miimon failure counter
Date: Fri, 31 Oct 2008 00:49:22 -0400 [thread overview]
Message-ID: <490A8E52.4010402@pobox.com> (raw)
In-Reply-To: <1225413676-13579-2-git-send-email-fubar@us.ibm.com>
Jay Vosburgh wrote:
> During the rework of the mii monitor for:
>
> commit f0c76d61779b153dbfb955db3f144c62d02173c2
> Author: Jay Vosburgh <fubar@us.ibm.com>
> Date: Wed Jul 2 18:21:58 2008 -0700
>
> bonding: refactor mii monitor
>
> I left out the increment of the link failure counter. This
> patch corrects that omission.
>
> Signed-off-by: Jay Vosburgh <fubar@us.ibm.com>
> ---
> drivers/net/bonding/bond_main.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
> index 832739f..85de1d0 100644
> --- a/drivers/net/bonding/bond_main.c
> +++ b/drivers/net/bonding/bond_main.c
> @@ -2376,6 +2376,9 @@ static void bond_miimon_commit(struct bonding *bond)
> continue;
>
> case BOND_LINK_DOWN:
> + if (slave->link_failure_count < UINT_MAX)
> + slave->link_failure_count++;
> +
> slave->link = BOND_LINK_DOWN;
applied 1-3
prev parent reply other threads:[~2008-10-31 4:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-31 0:41 [PATCH 2.6.28 0/3] bonding: two fixes and one small regression Jay Vosburgh
2008-10-31 0:41 ` [PATCH 1/3] bonding: fix miimon failure counter Jay Vosburgh
2008-10-31 0:41 ` [PATCH 2/3] bonding: Clean up resource leaks Jay Vosburgh
2008-10-31 0:41 ` [PATCH 3/3] bonding: fix panic when taking bond interface down before removing module Jay Vosburgh
2008-10-31 4:49 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=490A8E52.4010402@pobox.com \
--to=jgarzik@pobox.com \
--cc=davem@davemloft.net \
--cc=fubar@us.ibm.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).