From: Jeff Garzik <jeff@garzik.org>
To: akpm@linux-foundation.org
Cc: netdev@vger.kernel.org, rjw@sisk.pl, jbarnes@virtuousgeek.org,
shemminger@linux-foundation.org
Subject: Re: [patch 3/7] skge: adapt skge to use reworked PCI PM
Date: Fri, 31 Oct 2008 00:55:27 -0400 [thread overview]
Message-ID: <490A8FBF.5050304@garzik.org> (raw)
In-Reply-To: <200810292122.m9TLMFuV020166@imap1.linux-foundation.org>
akpm@linux-foundation.org wrote:
> From: Rafael J. Wysocki <rjw@sisk.pl>
>
> Adapt the skge driver to the reworked PCI PM
>
> * Use device_set_wakeup_enable() and friends as needed
> * Remove an open-coded reference to the standard PCI PM registers
> * Use pci_prepare_to_sleep() and pci_back_from_sleep() in the
> ->suspend() and ->resume() callbacks
> * Use the observation that it is sufficient to call pci_enable_wake()
> once, unless it fails
>
> Tested on Asus L5D (Yukon-Lite rev 7).
>
> Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
> Cc: Stephen Hemminger <shemminger@linux-foundation.org>
> Cc: Jeff Garzik <jeff@garzik.org>
> Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
>
> drivers/net/skge.c | 38 +++++++++++---------------------------
applied
prev parent reply other threads:[~2008-10-31 4:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-29 21:22 [patch 3/7] skge: adapt skge to use reworked PCI PM akpm
2008-10-31 4:55 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=490A8FBF.5050304@garzik.org \
--to=jeff@garzik.org \
--cc=akpm@linux-foundation.org \
--cc=jbarnes@virtuousgeek.org \
--cc=netdev@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).