* [PATCH] net: kconfig cleanup
@ 2008-10-31 7:41 Jeff Kirsher
2008-11-02 13:36 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Jeff Kirsher @ 2008-10-31 7:41 UTC (permalink / raw)
To: jeff; +Cc: netdev, davem, Jeff Kirsher, Andrew Gallatin
The bool kconfig option added to ixgbe and myri10ge for DCA is ambigous, so this
patch adds a description to the kconfig option.
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
CC: Andrew Gallatin <gallatin@myri.com>
---
drivers/net/Kconfig | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index f749b40..b13a7ff 100644
--- a/drivers/net/Kconfig
+++ b/drivers/net/Kconfig
@@ -2437,7 +2437,7 @@ config IXGBE
will be called ixgbe.
config IXGBE_DCA
- bool
+ bool "Enable DCA"
default y
depends on IXGBE && DCA && !(IXGBE=y && DCA=m)
@@ -2489,7 +2489,7 @@ config MYRI10GE
will be called myri10ge.
config MYRI10GE_DCA
- bool
+ bool "Enable DCA"
default y
depends on MYRI10GE && DCA && !(MYRI10GE=y && DCA=m)
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: kconfig cleanup
2008-10-31 7:41 [PATCH] net: kconfig cleanup Jeff Kirsher
@ 2008-11-02 13:36 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2008-11-02 13:36 UTC (permalink / raw)
To: Jeff Kirsher; +Cc: netdev, davem, Andrew Gallatin
Jeff Kirsher wrote:
> The bool kconfig option added to ixgbe and myri10ge for DCA is ambigous, so this
> patch adds a description to the kconfig option.
>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> CC: Andrew Gallatin <gallatin@myri.com>
> ---
>
> drivers/net/Kconfig | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> index f749b40..b13a7ff 100644
> --- a/drivers/net/Kconfig
> +++ b/drivers/net/Kconfig
> @@ -2437,7 +2437,7 @@ config IXGBE
> will be called ixgbe.
>
> config IXGBE_DCA
> - bool
> + bool "Enable DCA"
> default y
> depends on IXGBE && DCA && !(IXGBE=y && DCA=m)
>
> @@ -2489,7 +2489,7 @@ config MYRI10GE
> will be called myri10ge.
>
> config MYRI10GE_DCA
> - bool
> + bool "Enable DCA"
> default y
> depends on MYRI10GE && DCA && !(MYRI10GE=y && DCA=m)
If you're gonna do that, please add useful help text for the user who
has no idea what this means. (IGB_DCA needs this as well)
Jeff
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-11-02 13:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-10-31 7:41 [PATCH] net: kconfig cleanup Jeff Kirsher
2008-11-02 13:36 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).