From: Philip Craig <philipc@snapgear.com>
To: David Miller <davem@davemloft.net>
Cc: yjwei@cn.fujitsu.com, netdev@vger.kernel.org
Subject: Re: [PATCH 1/2] udp: Fix the SNMP counter of UDP_MIB_INDATAGRAMS
Date: Mon, 03 Nov 2008 11:46:38 +1000 [thread overview]
Message-ID: <490E57FE.804@snapgear.com> (raw)
In-Reply-To: <20081101.213529.60503932.davem@davemloft.net>
David Miller wrote:
> From: Wei Yongjun <yjwei@cn.fujitsu.com>
> Date: Sat, 01 Nov 2008 17:08:55 +0800
>
>> @@ -158,6 +159,8 @@ try_again:
>> else if (copied < ulen)
>> msg->msg_flags |= MSG_TRUNC;
>> + is_udp4 = (skb->protocol == htons(ETH_P_IP));
>> +
>> /*
>> * If checksum is needed at all, try to do it while copying the
>> * data. If the data is truncated, or if we only want a partial
> ...
>> sock_recv_timestamp(msg, sk, skb);
>> @@ -196,7 +204,7 @@ try_again:
>> sin6->sin6_flowinfo = 0;
>> sin6->sin6_scope_id = 0;
>> - if (skb->protocol == htons(ETH_P_IP))
>> + if (is_udp4)
>> ipv6_addr_set(&sin6->sin6_addr, 0, 0,
>
> This patch is corrupted in ways I thought I would never see in my
> entire life. Congratulations!
The patch looked okay to me, but judging by the bits you quoted,
the format=flowed is causing the problem.
next prev parent reply other threads:[~2008-11-03 1:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-01 9:08 [PATCH 1/2] udp: Fix the SNMP counter of UDP_MIB_INDATAGRAMS Wei Yongjun
2008-11-02 4:35 ` David Miller
2008-11-03 1:46 ` Philip Craig [this message]
2008-11-03 2:38 ` Wei Yongjun
2008-11-03 2:11 ` [Resent] " Wei Yongjun
2008-11-03 7:46 ` David Miller
2008-11-03 8:01 ` Pekka Savola
2008-11-03 8:08 ` David Miller
2008-11-03 2:14 ` [Resend] [PATCH 2/2] udp: Fix the SNMP counter of UDP_MIB_INERRORS Wei Yongjun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=490E57FE.804@snapgear.com \
--to=philipc@snapgear.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=yjwei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).