* [UPDATED PATCH] net: kconfig cleanup
@ 2008-11-03 4:30 Jeff Kirsher
2008-11-03 13:04 ` Andrew Gallatin
2008-11-03 20:26 ` Jeff Garzik
0 siblings, 2 replies; 3+ messages in thread
From: Jeff Kirsher @ 2008-11-03 4:30 UTC (permalink / raw)
To: jeff; +Cc: netdev, davem, Jeff Kirsher, Andrew Gallatin
The bool kconfig option added to ixgbe and myri10ge for DCA is ambigous,
so this patch adds a description to the kconfig option.
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
CC: Andrew Gallatin <gallatin@myri.com>
---
drivers/net/Kconfig | 18 +++++++++++++++---
1 files changed, 15 insertions(+), 3 deletions(-)
diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index f749b40..11f143f 100644
--- a/drivers/net/Kconfig
+++ b/drivers/net/Kconfig
@@ -2010,9 +2010,13 @@ config IGB_LRO
If in doubt, say N.
config IGB_DCA
- bool "Enable DCA"
+ bool "Direct Cache Access (DCA) Support"
default y
depends on IGB && DCA && !(IGB=y && DCA=m)
+ ---help---
+ Say Y here if you want to use Direct Cache Access (DCA) in the
+ driver. DCA is a method for warming the CPU cache before data
+ is used, with the intent of lessening the impact of cache misses.
source "drivers/net/ixp2000/Kconfig"
@@ -2437,9 +2441,13 @@ config IXGBE
will be called ixgbe.
config IXGBE_DCA
- bool
+ bool "Direct Cache Access (DCA) Support"
default y
depends on IXGBE && DCA && !(IXGBE=y && DCA=m)
+ ---help---
+ Say Y here if you want to use Direct Cache Access (DCA) in the
+ driver. DCA is a method for warming the CPU cache before data
+ is used, with the intent of lessening the impact of cache misses.
config IXGB
tristate "Intel(R) PRO/10GbE support"
@@ -2489,9 +2497,13 @@ config MYRI10GE
will be called myri10ge.
config MYRI10GE_DCA
- bool
+ bool "Direct Cache Access (DCA) Support"
default y
depends on MYRI10GE && DCA && !(MYRI10GE=y && DCA=m)
+ ---help---
+ Say Y here if you want to use Direct Cache Access (DCA) in the
+ driver. DCA is a method for warming the CPU cache before data
+ is used, with the intent of lessening the impact of cache misses.
config NETXEN_NIC
tristate "NetXen Multi port (1/10) Gigabit Ethernet NIC"
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [UPDATED PATCH] net: kconfig cleanup
2008-11-03 4:30 [UPDATED PATCH] net: kconfig cleanup Jeff Kirsher
@ 2008-11-03 13:04 ` Andrew Gallatin
2008-11-03 20:26 ` Jeff Garzik
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Gallatin @ 2008-11-03 13:04 UTC (permalink / raw)
To: Jeff Kirsher; +Cc: jeff, netdev, davem
Jeff Kirsher wrote:
> The bool kconfig option added to ixgbe and myri10ge for DCA is ambigous,
> so this patch adds a description to the kconfig option.
>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> CC: Andrew Gallatin <gallatin@myri.com>
> ---
>
> drivers/net/Kconfig | 18 +++++++++++++++---
> 1 files changed, 15 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> index f749b40..11f143f 100644
> --- a/drivers/net/Kconfig
> +++ b/drivers/net/Kconfig
> @@ -2010,9 +2010,13 @@ config IGB_LRO
> If in doubt, say N.
>
> config IGB_DCA
> - bool "Enable DCA"
> + bool "Direct Cache Access (DCA) Support"
> default y
> depends on IGB && DCA && !(IGB=y && DCA=m)
> + ---help---
> + Say Y here if you want to use Direct Cache Access (DCA) in the
> + driver. DCA is a method for warming the CPU cache before data
> + is used, with the intent of lessening the impact of cache misses.
>
> source "drivers/net/ixp2000/Kconfig"
>
> @@ -2437,9 +2441,13 @@ config IXGBE
> will be called ixgbe.
>
> config IXGBE_DCA
> - bool
> + bool "Direct Cache Access (DCA) Support"
> default y
> depends on IXGBE && DCA && !(IXGBE=y && DCA=m)
> + ---help---
> + Say Y here if you want to use Direct Cache Access (DCA) in the
> + driver. DCA is a method for warming the CPU cache before data
> + is used, with the intent of lessening the impact of cache misses.
>
> config IXGB
> tristate "Intel(R) PRO/10GbE support"
> @@ -2489,9 +2497,13 @@ config MYRI10GE
> will be called myri10ge.
>
> config MYRI10GE_DCA
> - bool
> + bool "Direct Cache Access (DCA) Support"
> default y
> depends on MYRI10GE && DCA && !(MYRI10GE=y && DCA=m)
> + ---help---
> + Say Y here if you want to use Direct Cache Access (DCA) in the
> + driver. DCA is a method for warming the CPU cache before data
> + is used, with the intent of lessening the impact of cache misses.
>
> config NETXEN_NIC
> tristate "NetXen Multi port (1/10) Gigabit Ethernet NIC"
This looks fine to me. Thank you for clarifying.
Drew
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [UPDATED PATCH] net: kconfig cleanup
2008-11-03 4:30 [UPDATED PATCH] net: kconfig cleanup Jeff Kirsher
2008-11-03 13:04 ` Andrew Gallatin
@ 2008-11-03 20:26 ` Jeff Garzik
1 sibling, 0 replies; 3+ messages in thread
From: Jeff Garzik @ 2008-11-03 20:26 UTC (permalink / raw)
To: Jeff Kirsher; +Cc: netdev, davem, Andrew Gallatin
Jeff Kirsher wrote:
> The bool kconfig option added to ixgbe and myri10ge for DCA is ambigous,
> so this patch adds a description to the kconfig option.
>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> CC: Andrew Gallatin <gallatin@myri.com>
> ---
>
> drivers/net/Kconfig | 18 +++++++++++++++---
> 1 files changed, 15 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> index f749b40..11f143f 100644
> --- a/drivers/net/Kconfig
> +++ b/drivers/net/Kconfig
> @@ -2010,9 +2010,13 @@ config IGB_LRO
> If in doubt, say N.
>
> config IGB_DCA
> - bool "Enable DCA"
> + bool "Direct Cache Access (DCA) Support"
> default y
> depends on IGB && DCA && !(IGB=y && DCA=m)
> + ---help---
> + Say Y here if you want to use Direct Cache Access (DCA) in the
> + driver. DCA is a method for warming the CPU cache before data
> + is used, with the intent of lessening the impact of cache misses.
>
> source "drivers/net/ixp2000/Kconfig"
>
> @@ -2437,9 +2441,13 @@ config IXGBE
> will be called ixgbe.
>
> config IXGBE_DCA
> - bool
> + bool "Direct Cache Access (DCA) Support"
> default y
> depends on IXGBE && DCA && !(IXGBE=y && DCA=m)
> + ---help---
> + Say Y here if you want to use Direct Cache Access (DCA) in the
> + driver. DCA is a method for warming the CPU cache before data
> + is used, with the intent of lessening the impact of cache misses.
>
> config IXGB
> tristate "Intel(R) PRO/10GbE support"
> @@ -2489,9 +2497,13 @@ config MYRI10GE
> will be called myri10ge.
>
> config MYRI10GE_DCA
> - bool
> + bool "Direct Cache Access (DCA) Support"
> default y
> depends on MYRI10GE && DCA && !(MYRI10GE=y && DCA=m)
> + ---help---
> + Say Y here if you want to use Direct Cache Access (DCA) in the
> + driver. DCA is a method for warming the CPU cache before data
> + is used, with the intent of lessening the impact of cache misses.
>
applied
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-11-03 20:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-11-03 4:30 [UPDATED PATCH] net: kconfig cleanup Jeff Kirsher
2008-11-03 13:04 ` Andrew Gallatin
2008-11-03 20:26 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).