From: Jeff Garzik <jgarzik@pobox.com>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Vitaly Bordug <vitb@kernel.crashing.org>,
Scott Wood <scottwood@freescale.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH] fs_enet: fix polling
Date: Mon, 03 Nov 2008 15:26:01 -0500 [thread overview]
Message-ID: <490F5E59.6090106@pobox.com> (raw)
In-Reply-To: <20081102144959.GA10869@x200.localdomain>
Alexey Dobriyan wrote:
> 1. compile fix for irqreturn_t type change
> 2. restore ->poll_controller after CONFIG_PPC_CPM_NEW_BINDING transition
>
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
> ---
>
> drivers/net/fs_enet/fs_enet-main.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> --- a/drivers/net/fs_enet/fs_enet-main.c
> +++ b/drivers/net/fs_enet/fs_enet-main.c
> @@ -1099,7 +1099,9 @@ static int __devinit fs_enet_probe(struct of_device *ofdev,
> ndev->stop = fs_enet_close;
> ndev->get_stats = fs_enet_get_stats;
> ndev->set_multicast_list = fs_set_multicast_list;
> -
> +#ifdef CONFIG_NET_POLL_CONTROLLER
> + ndev->poll_controller = fs_enet_netpoll;
> +#endif
> if (fpi->use_napi)
> netif_napi_add(ndev, &fep->napi, fs_enet_rx_napi,
> fpi->napi_weight);
> @@ -1209,7 +1211,7 @@ static void __exit fs_cleanup(void)
> static void fs_enet_netpoll(struct net_device *dev)
> {
> disable_irq(dev->irq);
> - fs_enet_interrupt(dev->irq, dev, NULL);
> + fs_enet_interrupt(dev->irq, dev);
> enable_irq(dev->irq);
> }
applied
prev parent reply other threads:[~2008-11-03 20:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-02 14:49 [PATCH] fs_enet: fix polling Alexey Dobriyan
2008-11-03 20:26 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=490F5E59.6090106@pobox.com \
--to=jgarzik@pobox.com \
--cc=adobriyan@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=scottwood@freescale.com \
--cc=vitb@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).