public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Tony Nguyen <anthony.l.nguyen@intel.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: <davem@davemloft.net>, <pabeni@redhat.com>, <edumazet@google.com>,
	<andrew+netdev@lunn.ch>, <netdev@vger.kernel.org>,
	Phani R Burra <phani.r.burra@intel.com>,
	<larysa.zaremba@intel.com>, <przemyslaw.kitszel@intel.com>,
	<aleksander.lobakin@intel.com>, <sridhar.samudrala@intel.com>,
	<anjali.singhai@intel.com>, <michal.swiatkowski@linux.intel.com>,
	<maciej.fijalkowski@intel.com>, <emil.s.tantilov@intel.com>,
	<madhu.chittim@intel.com>, <joshua.a.hay@intel.com>,
	<jacob.e.keller@intel.com>, <jayaprakash.shanmugam@intel.com>,
	<natalia.wochtman@intel.com>, <jiri@resnulli.us>,
	<horms@kernel.org>, <corbet@lwn.net>, <richardcochran@gmail.com>,
	<linux-doc@vger.kernel.org>, Bharath R <bharath.r@intel.com>,
	Samuel Salin <Samuel.salin@intel.com>
Subject: Re: [PATCH net-next 06/15] libie: add bookkeeping support for control queue messages
Date: Thu, 19 Mar 2026 09:17:10 -0700	[thread overview]
Message-ID: <490b9113-2935-404f-8054-ac496e0e2f21@intel.com> (raw)
In-Reply-To: <20260318193447.2e7b1f4d@kernel.org>

On 3/18/2026 7:34 PM, Jakub Kicinski wrote:
> On Tue, 17 Mar 2026 16:08:54 -0700 Tony Nguyen wrote:
>> From: Phani R Burra <phani.r.burra@intel.com>
>>
>> All send control queue messages are allocated/freed in libie itself and
>> tracked with the unique transaction (Xn) ids until they receive response or
>> time out. Responses can be received out of order, therefore transactions
>> are stored in an array and tracked though a bitmap.
>>
>> Pre-allocated DMA memory is used where possible. It reduces the driver
>> overhead in handling memory allocation/free and message timeouts.
> 
> Warning: include/linux/intel/libie/controlq.h:397 struct member 'force' not described in 'libie_ctlq_xn_clean_params'

Will fix this

> Please also look thru the AI reviews before you repost:
> https://netdev-ai.bots.linux.dev/ai-review.html?id=2078570c-9d93-4076-ace9-f275d8637314
> and:
> https://sashiko.dev/#/patchset/20260317230905.847744-1-anthony.l.nguyen%40intel.com

and look these over and adjust as needed.

Thanks,
Tony


  reply	other threads:[~2026-03-19 16:17 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-17 23:08 [PATCH net-next 00/15][pull request] Introduce iXD driver Tony Nguyen
2026-03-17 23:08 ` [PATCH net-next 01/15] virtchnl: create 'include/linux/intel' and move necessary header files Tony Nguyen
2026-03-17 23:08 ` [PATCH net-next 02/15] virtchnl: introduce control plane version fields Tony Nguyen
2026-03-17 23:08 ` [PATCH net-next 03/15] libie: add PCI device initialization helpers to libie Tony Nguyen
2026-03-17 23:08 ` [PATCH net-next 04/15] libeth: allow to create fill queues without NAPI Tony Nguyen
2026-03-17 23:08 ` [PATCH net-next 05/15] libie: add control queue support Tony Nguyen
2026-03-17 23:08 ` [PATCH net-next 06/15] libie: add bookkeeping support for control queue messages Tony Nguyen
2026-03-19  2:34   ` Jakub Kicinski
2026-03-19 16:17     ` Tony Nguyen [this message]
2026-03-17 23:08 ` [PATCH net-next 07/15] idpf: remove 'vport_params_reqd' field Tony Nguyen
2026-03-17 23:08 ` [PATCH net-next 08/15] idpf: refactor idpf to use libie_pci APIs Tony Nguyen
2026-03-17 23:08 ` [PATCH net-next 09/15] idpf: refactor idpf to use libie control queues Tony Nguyen
2026-03-17 23:08 ` [PATCH net-next 10/15] idpf: make mbx_task queueing and cancelling more consistent Tony Nguyen
2026-03-17 23:08 ` [PATCH net-next 11/15] idpf: print a debug message and bail in case of non-event ctlq message Tony Nguyen
2026-03-17 23:09 ` [PATCH net-next 12/15] ixd: add basic driver framework for Intel(R) Control Plane Function Tony Nguyen
2026-03-17 23:09 ` [PATCH net-next 13/15] ixd: add reset checks and initialize the mailbox Tony Nguyen
2026-03-17 23:09 ` [PATCH net-next 14/15] ixd: add the core initialization Tony Nguyen
2026-03-17 23:09 ` [PATCH net-next 15/15] ixd: add devlink support Tony Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=490b9113-2935-404f-8054-ac496e0e2f21@intel.com \
    --to=anthony.l.nguyen@intel.com \
    --cc=Samuel.salin@intel.com \
    --cc=aleksander.lobakin@intel.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=anjali.singhai@intel.com \
    --cc=bharath.r@intel.com \
    --cc=corbet@lwn.net \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=emil.s.tantilov@intel.com \
    --cc=horms@kernel.org \
    --cc=jacob.e.keller@intel.com \
    --cc=jayaprakash.shanmugam@intel.com \
    --cc=jiri@resnulli.us \
    --cc=joshua.a.hay@intel.com \
    --cc=kuba@kernel.org \
    --cc=larysa.zaremba@intel.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=maciej.fijalkowski@intel.com \
    --cc=madhu.chittim@intel.com \
    --cc=michal.swiatkowski@linux.intel.com \
    --cc=natalia.wochtman@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=phani.r.burra@intel.com \
    --cc=przemyslaw.kitszel@intel.com \
    --cc=richardcochran@gmail.com \
    --cc=sridhar.samudrala@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox