* [PATCH] hso should register as a WWAN rfkill device, not WLAN
@ 2008-11-04 11:11 Jonathan McDowell
2008-11-04 11:35 ` Paulius Zaleckas
0 siblings, 1 reply; 2+ messages in thread
From: Jonathan McDowell @ 2008-11-04 11:11 UTC (permalink / raw)
To: netdev; +Cc: Marcel Holtmann
Currently the hso driver registers a WLAN rfkill switch, which is
intended for 802.11 wireless network devices. Given that this driver
supports GSM/HSPA devices it's more appropriate to register a WWAN
rfkill switch type.
Signed-Off-By: Jonathan McDowell <noodles@earth.li>
-----
diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c
index 1164c52..3f49e83 100644
--- a/drivers/net/usb/hso.c
+++ b/drivers/net/usb/hso.c
@@ -2188,7 +2188,7 @@ static void hso_create_rfkill(struct hso_device *hso_dev,
char *rfkn;
hso_net->rfkill = rfkill_allocate(&interface_to_usbdev(interface)->dev,
- RFKILL_TYPE_WLAN);
+ RFKILL_TYPE_WWAN);
if (!hso_net->rfkill) {
dev_err(dev, "%s - Out of memory\n", __func__);
return;
-----
J.
--
Revd. Jonathan McDowell, ULC | Settle down, Beavis.
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] hso should register as a WWAN rfkill device, not WLAN
2008-11-04 11:11 [PATCH] hso should register as a WWAN rfkill device, not WLAN Jonathan McDowell
@ 2008-11-04 11:35 ` Paulius Zaleckas
0 siblings, 0 replies; 2+ messages in thread
From: Paulius Zaleckas @ 2008-11-04 11:35 UTC (permalink / raw)
To: Jonathan McDowell; +Cc: netdev, Marcel Holtmann, linux-usb
Jonathan McDowell wrote:
> Currently the hso driver registers a WLAN rfkill switch, which is
> intended for 802.11 wireless network devices. Given that this driver
> supports GSM/HSPA devices it's more appropriate to register a WWAN
> rfkill switch type.
Cool!!! We both sent the same patch almost at the same time :)
> Signed-Off-By: Jonathan McDowell <noodles@earth.li>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-11-04 11:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-11-04 11:11 [PATCH] hso should register as a WWAN rfkill device, not WLAN Jonathan McDowell
2008-11-04 11:35 ` Paulius Zaleckas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).