From: Patrick McHardy <kaber@trash.net>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: Jarek Poplawski <jarkao2@gmail.com>,
David Miller <davem@davemloft.net>,
herbert@gondor.apana.org.au, netdev@vger.kernel.org
Subject: Re: [PATCH 1/2] sch_netem: Remove classful functionality
Date: Tue, 04 Nov 2008 22:42:28 +0100 [thread overview]
Message-ID: <4910C1C4.3070309@trash.net> (raw)
In-Reply-To: <20081104082510.2dd57d04@extreme>
Stephen Hemminger wrote:
>> David, this makes sense to me, so please revert these two patches.
>> (Then, I think we're still at RFC stage.)
>>
>> Thanks.
>> Jarek P.
>>
>
> Keep Jarek's patch, I am working on dummynet compatiable rate control.
I'm still wondering what these incompatibilies are, in verifiable terms.
The dummynet algorithm looks like a not particulary cleverly implemented
TBF, but I can't see why it would behave any differently than a suitably
configured Linux TBF (cell size == 1) except for implementation differences
outside its scope (clock, timers etc).
next prev parent reply other threads:[~2008-11-04 21:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-31 13:20 [PATCH 1/2] sch_netem: Remove classful functionality Jarek Poplawski
2008-10-31 16:45 ` Stephen Hemminger
2008-11-02 7:37 ` David Miller
2008-11-03 8:29 ` Jarek Poplawski
2008-11-03 11:20 ` Patrick McHardy
2008-11-03 17:06 ` Stephen Hemminger
2008-11-04 9:56 ` Jarek Poplawski
2008-11-04 16:25 ` Stephen Hemminger
2008-11-04 21:42 ` Patrick McHardy [this message]
2008-11-04 11:04 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4910C1C4.3070309@trash.net \
--to=kaber@trash.net \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=jarkao2@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).