From: Patrick McHardy <kaber@trash.net>
To: David Miller <davem@davemloft.net>
Cc: adobriyan@gmail.com, herbert@gondor.apana.org.au, netdev@vger.kernel.org
Subject: Re: [PATCH] Fix ESP SA loading (by default)
Date: Wed, 05 Nov 2008 11:30:50 +0100 [thread overview]
Message-ID: <491175DA.7080300@trash.net> (raw)
In-Reply-To: <20081105.022619.151487044.davem@davemloft.net>
David Miller wrote:
> From: Patrick McHardy <kaber@trash.net>
> Date: Wed, 05 Nov 2008 11:03:18 +0100
>
>> David Miller wrote:
>>> About the rmmod thing, we can do something similar to how
>>> we handle nesting of irq_regs(). Ie. there are things that
>>> push and pop the stack of ->error_desc. rmmod operations
>>> could be one of those things
>> Alternatively we could simply strdup the error message (or copy it
>> to a reserved area to avoid running into memory allocation errors).
>> That avoids having to mess with foreign task structs when
>> unloading modules.
>
> Since the error message is "const char *" I don't see why
> you'd need to strdup() it ever, just the pointer is fine.
>
> Well, I guess we could run into problems with module unloading
> and the strings being from that module hmmm...
Yes, thats what I thought Alexey was referring to.
prev parent reply other threads:[~2008-11-05 10:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-01 4:37 [PATCH] Fix ESP SA loading (by default) Alexey Dobriyan
2008-11-01 5:04 ` Herbert Xu
2008-11-01 11:38 ` Alexey Dobriyan
2008-11-01 11:50 ` Herbert Xu
2008-11-02 4:33 ` David Miller
2008-11-03 0:16 ` Alexey Dobriyan
2008-11-03 1:04 ` Herbert Xu
2008-11-05 9:31 ` David Miller
2008-11-05 9:38 ` Herbert Xu
2008-11-05 9:54 ` Alexey Dobriyan
2008-11-05 9:55 ` David Miller
2008-11-05 10:03 ` Patrick McHardy
2008-11-05 10:26 ` David Miller
2008-11-05 10:30 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=491175DA.7080300@trash.net \
--to=kaber@trash.net \
--cc=adobriyan@gmail.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).