netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] mlx4_en: Start port error flow bug fix
@ 2008-11-05 14:53 Yevgeny Petrilin
  2008-11-06  5:43 ` [ofa-general] " Jeff Garzik
  0 siblings, 1 reply; 2+ messages in thread
From: Yevgeny Petrilin @ 2008-11-05 14:53 UTC (permalink / raw)
  To: Roland Dreier, jgarzik; +Cc: general, netdev, yevgenyp

Tried to deactivate rx ring that wasn't activated,
used wrong index.

Signed-off-by: Yevgeny Petrilin <yevgenyp@mellanox.co.il>
---
 drivers/net/mlx4/en_netdev.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/mlx4/en_netdev.c b/drivers/net/mlx4/en_netdev.c
index 12d736a..96e709d 100644
--- a/drivers/net/mlx4/en_netdev.c
+++ b/drivers/net/mlx4/en_netdev.c
@@ -706,7 +706,7 @@ tx_err:
 	mlx4_en_release_rss_steer(priv);
 rx_err:
 	for (i = 0; i < priv->rx_ring_num; i++)
-		mlx4_en_deactivate_rx_ring(priv, &priv->rx_ring[rx_index]);
+		mlx4_en_deactivate_rx_ring(priv, &priv->rx_ring[i]);
 cq_err:
 	while (rx_index--)
 		mlx4_en_deactivate_cq(priv, &priv->rx_cq[rx_index]);
-- 
1.5.4





^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [ofa-general] Re: [PATCH] mlx4_en: Start port error flow bug fix
  2008-11-05 14:53 [PATCH] mlx4_en: Start port error flow bug fix Yevgeny Petrilin
@ 2008-11-06  5:43 ` Jeff Garzik
  0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2008-11-06  5:43 UTC (permalink / raw)
  To: Yevgeny Petrilin; +Cc: netdev, Roland Dreier, general

Yevgeny Petrilin wrote:
> Tried to deactivate rx ring that wasn't activated,
> used wrong index.
> 
> Signed-off-by: Yevgeny Petrilin <yevgenyp@mellanox.co.il>
> ---
>  drivers/net/mlx4/en_netdev.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/mlx4/en_netdev.c b/drivers/net/mlx4/en_netdev.c
> index 12d736a..96e709d 100644
> --- a/drivers/net/mlx4/en_netdev.c
> +++ b/drivers/net/mlx4/en_netdev.c
> @@ -706,7 +706,7 @@ tx_err:
>  	mlx4_en_release_rss_steer(priv);
>  rx_err:
>  	for (i = 0; i < priv->rx_ring_num; i++)
> -		mlx4_en_deactivate_rx_ring(priv, &priv->rx_ring[rx_index]);
> +		mlx4_en_deactivate_rx_ring(priv, &priv->rx_ring[i]);
>  cq_err:

applied

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-11-06  5:43 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-11-05 14:53 [PATCH] mlx4_en: Start port error flow bug fix Yevgeny Petrilin
2008-11-06  5:43 ` [ofa-general] " Jeff Garzik

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).