From: Jeff Garzik <jgarzik@pobox.com>
To: Yevgeny Petrilin <yevgenyp@mellanox.co.il>
Cc: Roland Dreier <rdreier@cisco.com>,
general@lists.openfabrics.org, netdev@vger.kernel.org
Subject: Re: [PATCH] mlx4_en: Pause parameters per port
Date: Thu, 06 Nov 2008 00:45:22 -0500 [thread overview]
Message-ID: <49128472.7080607@pobox.com> (raw)
In-Reply-To: <4911B244.30205@mellanox.co.il>
Yevgeny Petrilin wrote:
> Before the change the driver reported the same pause parameters
> for all the ports, even only one of them was modified.
>
> Signed-off-by: Yevgeny Petrilin <yevgenyp@mellanox.co.il>
> ---
> drivers/net/mlx4/en_netdev.c | 8 ++++----
> drivers/net/mlx4/en_params.c | 30 ++++++++++++++++--------------
> drivers/net/mlx4/mlx4_en.h | 8 ++++----
> 3 files changed, 24 insertions(+), 22 deletions(-)
Is this a regression fix? It doesn't look like one to me, so I am
planning to hold this for 2.6.29 (davem/net-next-2.6.git), unless there
are problems with this plan?
Jeff
next prev parent reply other threads:[~2008-11-06 5:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-05 14:48 [ofa-general] [PATCH] mlx4_en: Pause parameters per port Yevgeny Petrilin
2008-11-05 17:58 ` Roland Dreier
2008-11-06 5:45 ` Jeff Garzik [this message]
2008-11-06 6:53 ` [ofa-general] Re: " Yevgeny Petrilin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49128472.7080607@pobox.com \
--to=jgarzik@pobox.com \
--cc=general@lists.openfabrics.org \
--cc=netdev@vger.kernel.org \
--cc=rdreier@cisco.com \
--cc=yevgenyp@mellanox.co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).