From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [PATCH 1/6] sfc: Correct address of gPXE boot configuration in EEPROM Date: Thu, 06 Nov 2008 00:53:44 -0500 Message-ID: <49128668.5060707@pobox.com> References: <20081104203244.GX7331@solarflare.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, linux-net-drivers@solarflare.com To: Ben Hutchings Return-path: Received: from srv5.dvmed.net ([207.36.208.214]:48999 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750703AbYKFFxt (ORCPT ); Thu, 6 Nov 2008 00:53:49 -0500 In-Reply-To: <20081104203244.GX7331@solarflare.com> Sender: netdev-owner@vger.kernel.org List-ID: Ben Hutchings wrote: > Due to a hardware bug, the originally assigned range cannot reliably > be used for boot configuration and must not be modifiable through > ethtool. > > Signed-off-by: Ben Hutchings > --- > drivers/net/sfc/ethtool.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/sfc/ethtool.c b/drivers/net/sfc/ethtool.c > index fa98af5..cd0d087 100644 > --- a/drivers/net/sfc/ethtool.c > +++ b/drivers/net/sfc/ethtool.c > @@ -174,8 +174,8 @@ static struct efx_ethtool_stat efx_ethtool_stats[] = { > > /* EEPROM range with gPXE configuration */ > #define EFX_ETHTOOL_EEPROM_MAGIC 0xEFAB > -#define EFX_ETHTOOL_EEPROM_MIN 0x100U > -#define EFX_ETHTOOL_EEPROM_MAX 0x400U > +#define EFX_ETHTOOL_EEPROM_MIN 0x800U > +#define EFX_ETHTOOL_EEPROM_MAX 0x1800U applied 1-5, I want a bit more time to review #6