From: Jeff Garzik <jeff@garzik.org>
To: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Subject: Re: [PATCH] ixgbe: Fix usage of netif_*_all_queues() with netif_carrier_{off|on}()
Date: Tue, 11 Nov 2008 03:33:45 -0500 [thread overview]
Message-ID: <49194369.7030902@garzik.org> (raw)
In-Reply-To: <20081107221608.13396.10693.stgit@gitlost.lost>
Jeff Kirsher wrote:
> From: PJ Waskiewicz <peter.p.waskiewicz.jr@intel.com>
>
> netif_carrier_off() is sufficient to stop Tx into the driver. Stopping the Tx
> queues is redundant and unnecessary. By the same token, netif_carrier_on()
> will be sufficient to re-enable Tx, so waking the queues is unnecessary.
Is this a fix as the subject says (2.6.28), or an optimization as the
description implies (2.6.29)?
AFAICS from a quick glance, things are not actually _broken_, are they?
Jeff
next prev parent reply other threads:[~2008-11-11 8:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-07 22:16 [PATCH] ixgbe: Fix usage of netif_*_all_queues() with netif_carrier_{off|on}() Jeff Kirsher
2008-11-11 8:33 ` Jeff Garzik [this message]
2008-11-11 8:37 ` Waskiewicz Jr, Peter P
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49194369.7030902@garzik.org \
--to=jeff@garzik.org \
--cc=davem@davemloft.net \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
--cc=peter.p.waskiewicz.jr@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).