From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andi Kleen <ak@linux.intel.com>
Subject: Re: [RFC PATCH 11/13] time sync: generic infrastructure to map between
 time stamps generated by a clock source and system time
Date: Tue, 11 Nov 2008 17:18:06 +0100
Message-ID: <4919B03E.1050504@linux.intel.com>
References: <1226414697.17450.852.camel@ecld0pohly> <1226415447.31699.10.camel@ecld0pohly>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org, Octavian Purdila <opurdila@ixiacom.com>,
	Stephen Hemminger <shemminger@vyatta.com>,
	Ingo Oeser <netdev@axxeo.de>,
	John Ronciak <john.ronciak@intel.com>,
	Eric Dumazet <dada1@cosmosbay.com>,
	Oliver Hartkopp <oliver@hartkopp.net>
To: Patrick Ohly <patrick.ohly@intel.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mga05.intel.com ([192.55.52.89]:42609 "EHLO
	fmsmga101.fm.intel.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org
	with ESMTP id S1753068AbYKKQRx (ORCPT
	<rfc822;netdev@vger.kernel.org>); Tue, 11 Nov 2008 11:17:53 -0500
In-Reply-To: <1226415447.31699.10.camel@ecld0pohly>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>


> +
> +int clocksync_offset(struct clocksync *sync,
> +		s64 *offset,
> +		u64 *hwtstamp)
> +{
> +	u64 starthw = 0, endhw = 0;
> +	struct {
> +		s64 offset;
> +		s64 duration_sys;
> +	} samples[100], 

That should be separately allocated to avoid potential stack overflow.

Also as a style nit there are normally no {} around single line
statements.


-Andi