netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Anders Grafström" <grfstrm@users.sourceforge.net>
To: "Brandeburg, Jesse" <jesse.brandeburg@intel.com>
Cc: Russell King - ARM Linux <linux@arm.linux.org.uk>,
	"linux-arm-kernel@lists.arm.linux.org.uk"
	<linux-arm-kernel@lists.arm.linux.org.uk>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	e1000-devel@lists.sourceforge.net
Subject: Re: Validation of DMA params breaks e100 driver (2.6.28-rc2)
Date: Fri, 14 Nov 2008 21:37:33 +0100	[thread overview]
Message-ID: <491DE18D.2070302@users.sourceforge.net> (raw)
In-Reply-To: <Pine.WNT.4.63.0811131718390.984@jbrandeb-desk.amr.corp.intel.com>

Brandeburg, Jesse wrote:
> On Fri, 31 Oct 2008, Russell King - ARM Linux wrote:
> 
>> On Thu, Oct 30, 2008 at 05:27:59PM +0100, Anders Grafström wrote:
>>> The e100 driver triggers BUG_ON(buf->direction != dir)
>>> by doing pci_map_single(..., PCI_DMA_BIDIRECTIONAL)
>>> and pci_dma_sync_single_for_device(..., PCI_DMA_TODEVICE).
>>>
>>> I'm guessing it's allowed to do that and that something like
>>> the patch below is called for?
>> No, it is not allowed to do that - that's why it's called "BUG_ON".
>> Changing the DMA direction, especially with dmabounce will result
>> in unexpected behaviour.
> 
> okay, how about this patch...  only compile tested as I couldn't get 
> net-next-2.6 to boot on my test machine.  I'll get some testing done on 
> this, but in the meantime....
> 
> e100: fix dma error in direction for mapping
> 
> From: Jesse Brandeburg <jesse.brandeburg@intel.com>

I failed to save this patch (flowed format?) but I applied it manually
to 2.6.28-rc4 and tried it. Appears to work.


-------------------------------------------------------------------
List admin: http://lists.arm.linux.org.uk/mailman/listinfo/linux-arm-kernel
FAQ:        http://www.arm.linux.org.uk/mailinglists/faq.php
Etiquette:  http://www.arm.linux.org.uk/mailinglists/etiquette.php

  parent reply	other threads:[~2008-11-14 20:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <4909E08F.9040306@users.sourceforge.net>
2008-10-31 21:01 ` Validation of DMA params breaks e100 driver (2.6.28-rc2) Russell King - ARM Linux
2008-11-14  1:21   ` Brandeburg, Jesse
2008-11-14  2:42     ` David Miller
2008-11-14 20:37     ` Anders Grafström [this message]
2008-11-14 22:30       ` Brandeburg, Jesse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=491DE18D.2070302@users.sourceforge.net \
    --to=grfstrm@users.sourceforge.net \
    --cc=e1000-devel@lists.sourceforge.net \
    --cc=jesse.brandeburg@intel.com \
    --cc=linux-arm-kernel@lists.arm.linux.org.uk \
    --cc=linux@arm.linux.org.uk \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).