From: Wang Chen <wangchen@cn.fujitsu.com>
To: David Miller <davem@davemloft.net>
Cc: jgarzik@pobox.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next]netdevice: 82596: Convert netdev->priv to netdev_priv
Date: Mon, 17 Nov 2008 14:58:35 +0800 [thread overview]
Message-ID: <4921161B.90605@cn.fujitsu.com> (raw)
In-Reply-To: <20081116.223637.108010315.davem@davemloft.net>
David Miller said the following on 2008-11-17 14:36:
> From: Wang Chen <wangchen@cn.fujitsu.com>
> Date: Mon, 17 Nov 2008 14:04:13 +0800
>
>> -#ifdef __mc68000__
>> - cache_push(virt_to_phys((void *)(dev->mem_start)), 4096);
>> - cache_clear(virt_to_phys((void *)(dev->mem_start)), 4096);
>> - kernel_set_cachemode((void *)(dev->mem_start), 4096, IOMAP_NOCACHE_SER);
>> -#endif
>
> Do you have any idea what this code is doing that you are removing?
>
> It's changing the cache mode of the memory behind ->mem_start because
> this "lp" struct is directly accessed by the hardware, and without
> these operations the CPU and the device won't see consistent
> values in the structure.
>
> Therefore your change breaks the driver.
>
Yes. I was wrong.
Will send a patch again.
Thank you for stopping my fool code.
next prev parent reply other threads:[~2008-11-17 6:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-17 6:04 [PATCH net-next]netdevice: 82596: Convert netdev->priv to netdev_priv Wang Chen
2008-11-17 6:36 ` David Miller
2008-11-17 6:58 ` Wang Chen [this message]
2008-11-17 9:24 ` [PATCH net-next v2]netdevice: " Wang Chen
2008-11-17 9:29 ` David Miller
2008-11-17 14:42 ` Wang Chen
2008-11-18 3:57 ` [PATCH net-next v3]netdevice: " Wang Chen
2008-11-20 9:01 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4921161B.90605@cn.fujitsu.com \
--to=wangchen@cn.fujitsu.com \
--cc=davem@davemloft.net \
--cc=jgarzik@pobox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).