From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: Re: [PATCH] net: Cleanup of af_unix Date: Mon, 17 Nov 2008 08:48:45 +0100 Message-ID: <492121DD.9030505@cosmosbay.com> References: <49210AE7.3050405@cosmosbay.com> <20081116.223209.239966240.davem@davemloft.net> <4921133D.6070800@cosmosbay.com> <1226907282.4037.31.camel@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: David Miller , netdev@vger.kernel.org To: Joe Perches Return-path: Received: from gw1.cosmosbay.com ([86.65.150.130]:58906 "EHLO gw1.cosmosbay.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752053AbYKQHs4 convert rfc822-to-8bit (ORCPT ); Mon, 17 Nov 2008 02:48:56 -0500 In-Reply-To: <1226907282.4037.31.camel@localhost> Sender: netdev-owner@vger.kernel.org List-ID: Joe Perches a =E9crit : > On Mon, 2008-11-17 at 07:46 +0100, Eric Dumazet wrote: >> [PATCH] net: Cleanup of af_unix >> >> This is a pure cleanup of net/unix/af_unix.c to meet current code st= yle standards >> >> Signed-off-by: Eric Dumazet >> ---=20 >> net/unix/af_unix.c | 117 ++++++++++++++++++++---------------------= -- >> 1 files changed, 55 insertions(+), 62 deletions(-) >> plain text document attachment (af_unix_cleanup.patch) >> diff --git a/net/unix/af_unix.c b/net/unix/af_unix.c >> index 4a39771..58db2a2 100644 >> --- a/net/unix/af_unix.c >> +++ b/net/unix/af_unix.c >> @@ -354,7 +353,7 @@ static void unix_sock_destructor(struct sock *sk= ) >> WARN_ON(!sk_unhashed(sk)); >> WARN_ON(sk->sk_socket); >> if (!sock_flag(sk, SOCK_DEAD)) { >> - printk("Attempt to release alive unix socket: %p\n", sk); >> + printk(KERN_DEBUG "Attempt to release alive unix socket: %p\n", s= k); >> return; >> } >> =20 >=20 > Well, perhaps not quite pure. > The KERN_ level selection is debatable. > This could or perhaps should be KERN_INFO. I agree. I was fooled by the next lines doing : printk(KERN_DEBUG "UNIX %p is destroyed, %d are still alive.\n", sk, atomic_read(&unix_nr_socks)); =20