From: Rick Jones <rick.jones2@hp.com>
To: Ben Greear <greearb@candelatech.com>
Cc: netdev@vger.kernel.org, Patrick McHardy <kaber@trash.net>
Subject: Re: ARP table question
Date: Mon, 17 Nov 2008 16:51:42 -0800 [thread overview]
Message-ID: <4922119E.6030601@hp.com> (raw)
In-Reply-To: <49220D75.1070803@candelatech.com>
Ben Greear wrote:
> Ok, here is the patch that implements this. The idea is to spread out
> arp requests when you do something like start 500 TCP connections on 500
> MAC-VLANs talking to 500 other MAC-VLANs.
>
> With a retrans timer of 1 sec, and a high volume of traffic, and a
> semi flaky network in between, my system will not resolve the ARPs
> and the retransmits overload my processors.
>
> Setting the retrans timer to 5 secs on my system also works, so I'm
> not sure if this patch is really required, but it might help keep arp
> requests somewhat random in cases where arp timers would otherwise
> try to all fire at the same time.
>
> This is against 2.6.25.20 plus my patches, but I believe it should
> apply to a clean 2.6.25.20 as well.
>
> Comments are welcome.
>
> Signed-Off-By Ben Greear<greearb@candelatech.com>
>
> Thanks,
> Ben
>
>
>
> ------------------------------------------------------------------------
>
> diff --git a/Documentation/filesystems/proc.txt b/Documentation/filesystems/proc.txt
> index 518ebe6..4c805b3 100644
> --- a/Documentation/filesystems/proc.txt
> +++ b/Documentation/filesystems/proc.txt
> @@ -2028,6 +2028,16 @@ Expression of retrans_time, which is deprecated, is in 1/100 seconds (for
> IPv4) or in jiffies (for IPv6).
> Expression of retrans_time_ms is in milliseconds.
>
> +
> +retrans_rand_backof_ms
> +----------------------
> +
> +This is an extra delay (ms) for the retransmit timer. A random value between
> +0 and retrans_rand_backof_ms will be added to the retrans_timer. Default
> +is zero. Setting this to a larger value will help large broadcast domains
> +resolve ARP (for instance, 500 mac-vlans talking to 500 other mac-vlans).
> +
> +
> unres_qlen
> ----------
> ...
>
> diff --git a/net/core/neighbour.c b/net/core/neighbour.c
> index 19b8e00..ec1f048 100644
> --- a/net/core/neighbour.c
> +++ b/net/core/neighbour.c
> @@ -765,6 +765,13 @@ static __inline__ int neigh_max_probes(struct neighbour *n)
> p->ucast_probes + p->app_probes + p->mcast_probes);
> }
>
> +static unsigned long neigh_rand_retry(struct neighbour* neigh) {
> + if (neigh->parms->retrans_rand_backoff) {
> + return net_random() % neigh->parms->retrans_rand_backoff;
> + }
> + return 0;
> +}
> +
> /* Called when a timer expires for a neighbour entry. */
I thought that mod was something we tried to avoid? Could you instead
use something that isn't random but perhaps varies among all the
requests? Say some of the low-order bits of the IP being resolved?
It wouldn't necessarily be "fair" to some destination IP's but it should
serve to spread things out a bit without having to generate a random
number and mod it.
rick jones
next prev parent reply other threads:[~2008-11-18 0:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <491B1600.4080505@candelatech.com>
[not found] ` <491B1841.9050404@candelatech.com>
2008-11-12 19:43 ` ARP table question Ben Greear
2008-11-12 22:10 ` Ben Greear
2008-11-17 3:16 ` David Miller
2008-11-17 18:17 ` Ben Greear
2008-11-18 0:33 ` Ben Greear
2008-11-18 0:51 ` Rick Jones [this message]
2008-11-18 1:23 ` Ben Greear
2008-11-18 1:39 ` Rick Jones
2008-11-18 1:50 ` Ben Greear
2008-11-20 8:33 ` David Miller
2008-11-20 17:23 ` Ben Greear
2008-11-20 17:33 ` Benjamin LaHaise
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4922119E.6030601@hp.com \
--to=rick.jones2@hp.com \
--cc=greearb@candelatech.com \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).