* [PATCH] sfc: Fix dependency for SFC_MTD
@ 2008-11-19 20:48 Ben Hutchings
2008-11-19 20:53 ` Ben Hutchings
0 siblings, 1 reply; 4+ messages in thread
From: Ben Hutchings @ 2008-11-19 20:48 UTC (permalink / raw)
To: David Miller
Cc: netdev, linux-net-drivers, Randy Dunlap, David Woodhouse,
Stephen Rothwell, linux-next
Randy Dunlap found that SFC_MTD was selected when sfc was built-in and
the MTD core was a module. Don't allow that combination.
---
drivers/net/sfc/Kconfig | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/sfc/Kconfig b/drivers/net/sfc/Kconfig
index 3e25fb3..c535408 100644
--- a/drivers/net/sfc/Kconfig
+++ b/drivers/net/sfc/Kconfig
@@ -14,7 +14,7 @@ config SFC
will be called sfc.
config SFC_MTD
bool "Solarflare Solarstorm SFC4000 flash MTD support"
- depends on SFC && MTD
+ depends on SFC && MTD && !(SFC=y && MTD=m)
default y
help
This exposes the on-board flash memory as an MTD device (e.g.
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] sfc: Fix dependency for SFC_MTD
2008-11-19 20:48 [PATCH] sfc: Fix dependency for SFC_MTD Ben Hutchings
@ 2008-11-19 20:53 ` Ben Hutchings
2008-11-19 21:37 ` Randy Dunlap
0 siblings, 1 reply; 4+ messages in thread
From: Ben Hutchings @ 2008-11-19 20:53 UTC (permalink / raw)
To: David Miller
Cc: netdev, linux-net-drivers, Randy Dunlap, David Woodhouse,
Stephen Rothwell, linux-next
Randy Dunlap found that SFC_MTD was selected when sfc was built-in and
the MTD core was a module. Don't allow that combination.
Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
---
drivers/net/sfc/Kconfig | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
Now with S-o-b; sorry for the spam.
Ben.
diff --git a/drivers/net/sfc/Kconfig b/drivers/net/sfc/Kconfig
index 3e25fb3..c535408 100644
--- a/drivers/net/sfc/Kconfig
+++ b/drivers/net/sfc/Kconfig
@@ -14,7 +14,7 @@ config SFC
will be called sfc.
config SFC_MTD
bool "Solarflare Solarstorm SFC4000 flash MTD support"
- depends on SFC && MTD
+ depends on SFC && MTD && !(SFC=y && MTD=m)
default y
help
This exposes the on-board flash memory as an MTD device (e.g.
--
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] sfc: Fix dependency for SFC_MTD
2008-11-19 20:53 ` Ben Hutchings
@ 2008-11-19 21:37 ` Randy Dunlap
2008-11-20 12:17 ` David Miller
0 siblings, 1 reply; 4+ messages in thread
From: Randy Dunlap @ 2008-11-19 21:37 UTC (permalink / raw)
To: Ben Hutchings
Cc: David Miller, netdev, linux-net-drivers, David Woodhouse,
Stephen Rothwell, linux-next
Ben Hutchings wrote:
> Randy Dunlap found that SFC_MTD was selected when sfc was built-in and
> the MTD core was a module. Don't allow that combination.
>
> Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Acked-by: Randy Dunlap <randy.dunlap@oracle.com>
I realized that this problem came up because SFC_MTD is a boolean
that depends on tristates, so the boolean is set (=y) when
SFC=y or SFC=m. Thus extra handling for it is needed,
like Ben did here.
> ---
> drivers/net/sfc/Kconfig | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> Now with S-o-b; sorry for the spam.
>
> Ben.
>
> diff --git a/drivers/net/sfc/Kconfig b/drivers/net/sfc/Kconfig
> index 3e25fb3..c535408 100644
> --- a/drivers/net/sfc/Kconfig
> +++ b/drivers/net/sfc/Kconfig
> @@ -14,7 +14,7 @@ config SFC
> will be called sfc.
> config SFC_MTD
> bool "Solarflare Solarstorm SFC4000 flash MTD support"
> - depends on SFC && MTD
> + depends on SFC && MTD && !(SFC=y && MTD=m)
> default y
> help
> This exposes the on-board flash memory as an MTD device (e.g.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] sfc: Fix dependency for SFC_MTD
2008-11-19 21:37 ` Randy Dunlap
@ 2008-11-20 12:17 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2008-11-20 12:17 UTC (permalink / raw)
To: randy.dunlap
Cc: bhutchings, netdev, linux-net-drivers, dwmw2, sfr, linux-next
From: Randy Dunlap <randy.dunlap@oracle.com>
Date: Wed, 19 Nov 2008 13:37:50 -0800
> Ben Hutchings wrote:
> > Randy Dunlap found that SFC_MTD was selected when sfc was built-in and
> > the MTD core was a module. Don't allow that combination.
> >
> > Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
>
> Acked-by: Randy Dunlap <randy.dunlap@oracle.com>
>
> I realized that this problem came up because SFC_MTD is a boolean
> that depends on tristates, so the boolean is set (=y) when
> SFC=y or SFC=m. Thus extra handling for it is needed,
> like Ben did here.
Applied, thanks everyone.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-11-20 12:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-11-19 20:48 [PATCH] sfc: Fix dependency for SFC_MTD Ben Hutchings
2008-11-19 20:53 ` Ben Hutchings
2008-11-19 21:37 ` Randy Dunlap
2008-11-20 12:17 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).