From: Eric Dumazet <dada1@cosmosbay.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: [RFC] question about inet_listen_lock(), and [PATCH] net: listening_hash get a spinlock per bucket
Date: Thu, 20 Nov 2008 09:47:26 +0100 [thread overview]
Message-ID: <4925241E.7090505@cosmosbay.com> (raw)
In-Reply-To: <20081120.004103.45482570.davem@davemloft.net>
David Miller a écrit :
> From: Eric Dumazet <dada1@cosmosbay.com>
> Date: Mon, 17 Nov 2008 17:21:19 +0100
>
>> [PATCH] net: listening_hash get a spinlock per bucket
>>
>> This patch prepares RCU migration of listening_hash table for
>> TCP/DCCP protocols.
>>
>> listening_hash table being small (32 slots per protocol), we add
>> a spinlock for each slot, instead of a single rwlock for whole table.
>>
>> This should reduce hold time of readers, and writers concurrency.
>>
>> Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>
>
> Ok it looks indeed as this sleeping thing was just a queer way to wait
> when there was some thread dumping listening sockets. I guess it must
> have been _really_ slow back when that was written by Alexey :)
>
> I've applied your patch to net-next-2.6, thanks Eric!
>
>
Thanks a lot David for your analysis, I will continue the work further.
prev parent reply other threads:[~2008-11-20 8:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-17 16:21 [RFC] question about inet_listen_lock(), and [PATCH] net: listening_hash get a spinlock per bucket Eric Dumazet
2008-11-19 23:41 ` David Miller
2008-11-20 8:41 ` David Miller
2008-11-20 8:47 ` Eric Dumazet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4925241E.7090505@cosmosbay.com \
--to=dada1@cosmosbay.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).