From: Wang Chen <wangchen@cn.fujitsu.com>
To: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, jeff@garzik.org,
Alexander Duyck <alexander.h.duyck@intel.com>,
Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
Subject: Re: [NET-NEXT v4 PATCH 1/5] ixgbe: this patch adds support for DCB to the kernel and ixgbe driver
Date: Fri, 21 Nov 2008 17:14:16 +0800 [thread overview]
Message-ID: <49267BE8.6020205@cn.fujitsu.com> (raw)
In-Reply-To: <20081121020055.22180.24154.stgit@gitlost.lost>
Jeff Kirsher said the following on 2008-11-21 10:00:
> diff --git a/drivers/net/ixgbe/ixgbe_ethtool.c b/drivers/net/ixgbe/ixgbe_ethtool.c
> index a610016..aaa4404 100644
> --- a/drivers/net/ixgbe/ixgbe_ethtool.c
> +++ b/drivers/net/ixgbe/ixgbe_ethtool.c
> @@ -97,9 +97,18 @@ static struct ixgbe_stats ixgbe_gstrings_stats[] = {
> ((((struct ixgbe_adapter *)netdev_priv(netdev))->num_tx_queues + \
> ((struct ixgbe_adapter *)netdev_priv(netdev))->num_rx_queues) * \
> (sizeof(struct ixgbe_queue_stats) / sizeof(u64)))
> -#define IXGBE_STATS_LEN (IXGBE_GLOBAL_STATS_LEN + IXGBE_QUEUE_STATS_LEN)
> #define IXGBE_GLOBAL_STATS_LEN ARRAY_SIZE(ixgbe_gstrings_stats)
> -#define IXGBE_STATS_LEN (IXGBE_GLOBAL_STATS_LEN + IXGBE_QUEUE_STATS_LEN)
> +#define IXGBE_PB_STATS_LEN ( \
> + (((struct ixgbe_adapter *)netdev->priv)->flags & \
Dave, please don't hate me. :)
I know you've applied it.
But I don't want this directly reference of netdev->priv.
next prev parent reply other threads:[~2008-11-21 9:14 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-21 2:00 [NET-NEXT v4 PATCH 1/5] ixgbe: this patch adds support for DCB to the kernel and ixgbe driver Jeff Kirsher
2008-11-21 2:01 ` [NET-NEXT v4 PATCH 2/5] DCB: Add interface to query for the DCB capabilities of an device Jeff Kirsher
2008-11-21 5:07 ` David Miller
2008-11-21 2:01 ` [NET-NEXT v4 PATCH 3/5] DCB: Add interface to query # of TCs supported by device Jeff Kirsher
2008-11-21 5:08 ` David Miller
2008-11-21 2:01 ` [NET-NEXT v4 PATCH 4/5] DCB: Add interface to query the state of PFC feature Jeff Kirsher
2008-11-21 5:09 ` David Miller
2008-11-21 2:02 ` [NET-NEXT v4 PATCH 5/5] DCB: Add support for DCB BCN Jeff Kirsher
2008-11-21 5:10 ` David Miller
2008-11-21 5:02 ` [NET-NEXT v4 PATCH 1/5] ixgbe: this patch adds support for DCB to the kernel and ixgbe driver David Miller
2008-11-21 9:14 ` Wang Chen [this message]
2008-11-21 9:21 ` David Miller
2008-11-21 9:32 ` [NET-NEXT PATCH] ixgbe: convert directly reference of netdev->priv Wang Chen
2008-11-21 9:57 ` David Miller
2008-11-21 13:06 ` [NET-NEXT v4 PATCH 1/5] ixgbe: this patch adds support for DCB to the kernel and ixgbe driver Patrick McHardy
2008-11-21 17:58 ` Roland Dreier
2008-11-21 22:20 ` Jeff Kirsher
2008-11-22 0:48 ` David Miller
2008-11-22 0:57 ` Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49267BE8.6020205@cn.fujitsu.com \
--to=wangchen@cn.fujitsu.com \
--cc=alexander.h.duyck@intel.com \
--cc=davem@davemloft.net \
--cc=jeff@garzik.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
--cc=peter.p.waskiewicz.jr@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).