From: Patrick McHardy <kaber@trash.net>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Philip Craig <philipc@snapgear.com>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org
Subject: Re: bridge: Fix update_pmtu crash with GRE
Date: Mon, 24 Nov 2008 13:35:46 +0100 [thread overview]
Message-ID: <492A9FA2.1020809@trash.net> (raw)
In-Reply-To: <20081124064957.GA15999@gondor.apana.org.au>
Herbert Xu wrote:
> Looks like this fell through the cracks:
>
> bridge: Fix update_pmtu crash with GRE
>
> As GRE tries to call the update_pmtu function on skb->dst and
> bridge supplies an skb->dst that has a NULL ops field, all is
> not well.
>
> This patch fixes this by giving the bridge device an ops field
> with an update_pmtu function. For the moment I've left all
> other fields blank but we can fill them in later should the
> need arise.
>
> Based on report and patch by Philip Craig.
Applied, thanks Herbert.
next prev parent reply other threads:[~2008-11-24 12:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-09 7:04 [0/4] gre: Ethernet over GRE Herbert Xu
2008-10-09 7:05 ` [PATCH 1/4] gre: Use needed_headroom Herbert Xu
2008-10-09 7:05 ` [PATCH 2/4] gre: Move MTU setting out of ipgre_tunnel_bind_dev Herbert Xu
2008-10-09 7:05 ` [PATCH 3/4] gre: Add netlink interface Herbert Xu
2008-10-09 7:05 ` [PATCH 4/4] gre: Add Transparent Ethernet Bridging Herbert Xu
2008-10-09 8:43 ` Philip Craig
2008-10-09 10:39 ` Herbert Xu
2008-11-24 6:49 ` bridge: Fix update_pmtu crash with GRE Herbert Xu
2008-11-24 12:35 ` Patrick McHardy [this message]
2008-10-09 11:21 ` [PATCH 4/4] gre: Add Transparent Ethernet Bridging Herbert Xu
2008-10-09 7:08 ` ip: gre: Add GRE configuration support through rtnl_link Herbert Xu
2008-10-11 13:03 ` Herbert Xu
2008-10-09 11:23 ` [PATCH 5/4] inet: Make tunnel RX/TX byte counters more consistent Herbert Xu
2008-10-09 19:03 ` David Miller
2008-10-09 12:12 ` [0/4] gre: Ethernet over GRE Patrick McHardy
2008-10-09 19:01 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=492A9FA2.1020809@trash.net \
--to=kaber@trash.net \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
--cc=philipc@snapgear.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).