From mboxrd@z Thu Jan  1 00:00:00 1970
From: Patrick McHardy <kaber@trash.net>
Subject: Re: [PATCH] pkt_sched: sch_api: Remove qdisc_list_lock
Date: Tue, 25 Nov 2008 12:46:25 +0100
Message-ID: <492BE591.8060202@trash.net>
References: <20081125112941.GA8136@ff.dom.local> <492BE515.1080703@trash.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Cc: David Miller <davem@davemloft.net>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	netdev@vger.kernel.org
To: Jarek Poplawski <jarkao2@gmail.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from stinky.trash.net ([213.144.137.162]:56450 "EHLO
	stinky.trash.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752187AbYKYLqg (ORCPT
	<rfc822;netdev@vger.kernel.org>); Tue, 25 Nov 2008 06:46:36 -0500
In-Reply-To: <492BE515.1080703@trash.net>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

Patrick McHardy wrote:
> Jarek Poplawski wrote:
>> After implementing qdisc->ops->peek() there is no more calling
>> qdisc_tree_decrease_qlen() without rtnl_lock(), so qdisc_list_lock
>> added by commit: f6e0b239a2657ea8cb67f0d83d0bfdbfd19a481b "pkt_sched:
>> Fix qdisc list locking" can be removed.
> 
> I might be misunderstanding something, but qdisc_tree_decrease_qlen()
> doesn't need rtnl_lock() but the sch_tree_lock() since it changes
> q.qlen.

OK I see now, rtnl_lock() was taken to protect the parent qdisc lookup.
In that case it seems fine, all callers are holding both sch_tree_lock()
and rtnl_lock().