From: Randy Dunlap <randy.dunlap@oracle.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, jgarzik@pobox.com, alan@lxorguk.ukuu.org.uk
Subject: Re: [PATCH] net: hp-plus uses eip_poll
Date: Tue, 25 Nov 2008 21:43:32 -0800 [thread overview]
Message-ID: <492CE204.4090904@oracle.com> (raw)
In-Reply-To: <20081125.210524.248687025.davem@davemloft.net>
David Miller wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
> Date: Tue, 25 Nov 2008 19:54:00 -0800
>
>> From: Randy Dunlap <randy.dunlap@oracle.com>
>>
>> hp-plus uses 8390p.c, so it should use eip_poll(), not ei_poll().
>>
>> drivers/built-in.o: In function `hpp_probe1':
>> hp-plus.c:(.init.text+0x9cbd): undefined reference to `ei_poll'
>>
>> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
>
> I'll apply this to net-2.6
>
> But can you take a look at what I just pushed out to
> net-next-2.6 wrt. this driver and give me a hand untangling
> things there?
>
> Thanks a lot Randy!
Looks to me like both of this week's hp-plus patches (one to
drivers/net/Makefile & one to drivers/net/hp-plus.c) are
still needed there (unless you applied those patches but
didn't push or the push isn't showing up yet).
--
~Randy
next prev parent reply other threads:[~2008-11-26 5:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-26 3:54 [PATCH] net: hp-plus uses eip_poll Randy Dunlap
2008-11-26 5:05 ` David Miller
2008-11-26 5:43 ` Randy Dunlap [this message]
2008-11-26 5:49 ` David Miller
2008-11-26 6:03 ` Randy Dunlap
2008-11-27 8:26 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=492CE204.4090904@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=davem@davemloft.net \
--cc=jgarzik@pobox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).