* [PATCH] net: hp-plus uses eip_poll
@ 2008-11-26 3:54 Randy Dunlap
2008-11-26 5:05 ` David Miller
0 siblings, 1 reply; 6+ messages in thread
From: Randy Dunlap @ 2008-11-26 3:54 UTC (permalink / raw)
To: netdev; +Cc: davem, jgarzik, alan
From: Randy Dunlap <randy.dunlap@oracle.com>
hp-plus uses 8390p.c, so it should use eip_poll(), not ei_poll().
drivers/built-in.o: In function `hpp_probe1':
hp-plus.c:(.init.text+0x9cbd): undefined reference to `ei_poll'
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
drivers/net/hp-plus.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-next-20081125.orig/drivers/net/hp-plus.c
+++ linux-next-20081125/drivers/net/hp-plus.c
@@ -229,7 +229,7 @@ static int __init hpp_probe1(struct net_
dev->open = &hpp_open;
dev->stop = &hpp_close;
#ifdef CONFIG_NET_POLL_CONTROLLER
- dev->poll_controller = ei_poll;
+ dev->poll_controller = eip_poll;
#endif
ei_status.name = name;
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] net: hp-plus uses eip_poll
2008-11-26 3:54 [PATCH] net: hp-plus uses eip_poll Randy Dunlap
@ 2008-11-26 5:05 ` David Miller
2008-11-26 5:43 ` Randy Dunlap
0 siblings, 1 reply; 6+ messages in thread
From: David Miller @ 2008-11-26 5:05 UTC (permalink / raw)
To: randy.dunlap; +Cc: netdev, jgarzik, alan
From: Randy Dunlap <randy.dunlap@oracle.com>
Date: Tue, 25 Nov 2008 19:54:00 -0800
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> hp-plus uses 8390p.c, so it should use eip_poll(), not ei_poll().
>
> drivers/built-in.o: In function `hpp_probe1':
> hp-plus.c:(.init.text+0x9cbd): undefined reference to `ei_poll'
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
I'll apply this to net-2.6
But can you take a look at what I just pushed out to
net-next-2.6 wrt. this driver and give me a hand untangling
things there?
Thanks a lot Randy!
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] net: hp-plus uses eip_poll
2008-11-26 5:05 ` David Miller
@ 2008-11-26 5:43 ` Randy Dunlap
2008-11-26 5:49 ` David Miller
0 siblings, 1 reply; 6+ messages in thread
From: Randy Dunlap @ 2008-11-26 5:43 UTC (permalink / raw)
To: David Miller; +Cc: netdev, jgarzik, alan
David Miller wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
> Date: Tue, 25 Nov 2008 19:54:00 -0800
>
>> From: Randy Dunlap <randy.dunlap@oracle.com>
>>
>> hp-plus uses 8390p.c, so it should use eip_poll(), not ei_poll().
>>
>> drivers/built-in.o: In function `hpp_probe1':
>> hp-plus.c:(.init.text+0x9cbd): undefined reference to `ei_poll'
>>
>> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
>
> I'll apply this to net-2.6
>
> But can you take a look at what I just pushed out to
> net-next-2.6 wrt. this driver and give me a hand untangling
> things there?
>
> Thanks a lot Randy!
Looks to me like both of this week's hp-plus patches (one to
drivers/net/Makefile & one to drivers/net/hp-plus.c) are
still needed there (unless you applied those patches but
didn't push or the push isn't showing up yet).
--
~Randy
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] net: hp-plus uses eip_poll
2008-11-26 5:43 ` Randy Dunlap
@ 2008-11-26 5:49 ` David Miller
2008-11-26 6:03 ` Randy Dunlap
0 siblings, 1 reply; 6+ messages in thread
From: David Miller @ 2008-11-26 5:49 UTC (permalink / raw)
To: randy.dunlap; +Cc: netdev, jgarzik, alan
From: Randy Dunlap <randy.dunlap@oracle.com>
Date: Tue, 25 Nov 2008 21:43:32 -0800
> David Miller wrote:
> > From: Randy Dunlap <randy.dunlap@oracle.com>
> > Date: Tue, 25 Nov 2008 19:54:00 -0800
> >
> >> From: Randy Dunlap <randy.dunlap@oracle.com>
> >>
> >> hp-plus uses 8390p.c, so it should use eip_poll(), not ei_poll().
> >>
> >> drivers/built-in.o: In function `hpp_probe1':
> >> hp-plus.c:(.init.text+0x9cbd): undefined reference to `ei_poll'
> >>
> >> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> >
> > I'll apply this to net-2.6
> >
> > But can you take a look at what I just pushed out to
> > net-next-2.6 wrt. this driver and give me a hand untangling
> > things there?
> >
> > Thanks a lot Randy!
>
> Looks to me like both of this week's hp-plus patches (one to
> drivers/net/Makefile & one to drivers/net/hp-plus.c) are
> still needed there (unless you applied those patches but
> didn't push or the push isn't showing up yet).
Ok. I will need to merge.
But in net-next-2.6 that ->poll_controller is set in the
hp-plus.c driver's netdev_ops structure. That's what I
wanted you to look at.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] net: hp-plus uses eip_poll
2008-11-26 5:49 ` David Miller
@ 2008-11-26 6:03 ` Randy Dunlap
2008-11-27 8:26 ` David Miller
0 siblings, 1 reply; 6+ messages in thread
From: Randy Dunlap @ 2008-11-26 6:03 UTC (permalink / raw)
To: David Miller; +Cc: randy.dunlap, netdev, jgarzik, alan
David Miller wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
> Date: Tue, 25 Nov 2008 21:43:32 -0800
>
>> David Miller wrote:
>>> From: Randy Dunlap <randy.dunlap@oracle.com>
>>> Date: Tue, 25 Nov 2008 19:54:00 -0800
>>>
>>>> From: Randy Dunlap <randy.dunlap@oracle.com>
>>>>
>>>> hp-plus uses 8390p.c, so it should use eip_poll(), not ei_poll().
>>>>
>>>> drivers/built-in.o: In function `hpp_probe1':
>>>> hp-plus.c:(.init.text+0x9cbd): undefined reference to `ei_poll'
>>>>
>>>> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
>>> I'll apply this to net-2.6
>>>
>>> But can you take a look at what I just pushed out to
>>> net-next-2.6 wrt. this driver and give me a hand untangling
>>> things there?
>>>
>>> Thanks a lot Randy!
>> Looks to me like both of this week's hp-plus patches (one to
>> drivers/net/Makefile & one to drivers/net/hp-plus.c) are
>> still needed there (unless you applied those patches but
>> didn't push or the push isn't showing up yet).
>
> Ok. I will need to merge.
>
> But in net-next-2.6 that ->poll_controller is set in the
> hp-plus.c driver's netdev_ops structure. That's what I
> wanted you to look at.
OK, it still uses ei_poll instead of eip_poll.
Needs to be changed.
--
~Randy
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] net: hp-plus uses eip_poll
2008-11-26 6:03 ` Randy Dunlap
@ 2008-11-27 8:26 ` David Miller
0 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2008-11-27 8:26 UTC (permalink / raw)
To: randy.dunlap; +Cc: netdev, jgarzik, alan
From: Randy Dunlap <randy.dunlap@oracle.com>
Date: Tue, 25 Nov 2008 22:03:16 -0800
> David Miller wrote:
> > From: Randy Dunlap <randy.dunlap@oracle.com>
> > Date: Tue, 25 Nov 2008 21:43:32 -0800
> >
> >> David Miller wrote:
> >>> From: Randy Dunlap <randy.dunlap@oracle.com>
> >>> Date: Tue, 25 Nov 2008 19:54:00 -0800
> >>>
> >>>> From: Randy Dunlap <randy.dunlap@oracle.com>
> >>>>
> >>>> hp-plus uses 8390p.c, so it should use eip_poll(), not ei_poll().
> >>>>
> >>>> drivers/built-in.o: In function `hpp_probe1':
> >>>> hp-plus.c:(.init.text+0x9cbd): undefined reference to `ei_poll'
> >>>>
> >>>> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> >>> I'll apply this to net-2.6
> >>>
> >>> But can you take a look at what I just pushed out to
> >>> net-next-2.6 wrt. this driver and give me a hand untangling
> >>> things there?
> >>>
> >>> Thanks a lot Randy!
> >> Looks to me like both of this week's hp-plus patches (one to
> >> drivers/net/Makefile & one to drivers/net/hp-plus.c) are
> >> still needed there (unless you applied those patches but
> >> didn't push or the push isn't showing up yet).
> >
> > Ok. I will need to merge.
> >
> > But in net-next-2.6 that ->poll_controller is set in the
> > hp-plus.c driver's netdev_ops structure. That's what I
> > wanted you to look at.
>
> OK, it still uses ei_poll instead of eip_poll.
> Needs to be changed.
I took care of this when I merged net-2.6 into net-next-2.6
a few moments ago.
Thanks Randy!
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2008-11-27 8:26 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-11-26 3:54 [PATCH] net: hp-plus uses eip_poll Randy Dunlap
2008-11-26 5:05 ` David Miller
2008-11-26 5:43 ` Randy Dunlap
2008-11-26 5:49 ` David Miller
2008-11-26 6:03 ` Randy Dunlap
2008-11-27 8:26 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).