From: Patrick McHardy <kaber@trash.net>
To: Michal Soltys <soltys@ziu.info>
Cc: Linux Netdev List <netdev@vger.kernel.org>
Subject: Re: Question about HFSC atm+man patches
Date: Thu, 27 Nov 2008 11:48:43 +0100 [thread overview]
Message-ID: <492E7B0B.8000601@trash.net> (raw)
In-Reply-To: <492DD399.4040801@ziu.info>
Michal Soltys wrote:
> One question regarding size tables:
>
> Should I assume that subsequent qdiscs attached to HFSC leaves will not
> use [different] size tables ?
>
> This is currently the case, but from the perspective of a generic
> solution - if some inner qdisc changes pkt_len stored in cb area during
> qdisc_enqueue, then HFSC might get wrong size during peek operation.
>
> As leaves will usually have "simple" work-conserving qdiscs attached,
> this is probably not an issue, but ...
Using different size tables for inner qdiscs is supposed to work.
What is the "wrong size"? ->peek() should return a packet with the
size the same as ->dequeue() would, which I think it does.
next prev parent reply other threads:[~2008-11-27 10:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <49292F54.4020803@ziu.info>
2008-11-23 14:05 ` Question about HFSC atm+man patches Patrick McHardy
2008-11-24 13:56 ` Michal Soltys
2008-11-24 14:11 ` Patrick McHardy
2008-11-24 23:21 ` Michal Soltys
2008-11-26 22:54 ` Michal Soltys
2008-11-27 10:48 ` Patrick McHardy [this message]
2008-11-27 23:17 ` Michal Soltys
2008-12-04 13:55 ` Question - size tables implementation Michal Soltys
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=492E7B0B.8000601@trash.net \
--to=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=soltys@ziu.info \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).