netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jan-Bernd Themann <ossthema@de.ibm.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org,
	linux-kernel <linux-kernel@vger.kernel.org>,
	tklein@de.ibm.com, Christoph Raisch <raisch@de.ibm.com>,
	jb.billaud@gmail.com, hering2@de.ibm.com
Subject: [PATCH] lro: IP fragment checking
Date: Mon, 01 Dec 2008 09:58:55 +0100	[thread overview]
Message-ID: <4933A74F.3050809@de.ibm.com> (raw)

This patch prevents that ip fragmented TCP packets are considered vaild
for aggregation

Regards,

Jan-Bernd

---



 net/ipv4/inet_lro.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/net/ipv4/inet_lro.c b/net/ipv4/inet_lro.c
index cfd034a..1f9159d 100644
--- a/net/ipv4/inet_lro.c
+++ b/net/ipv4/inet_lro.c
@@ -64,6 +64,9 @@ static int lro_tcp_ip_check(struct iphdr *iph, struct tcphdr *tcph,
 	if (iph->ihl != IPH_LEN_WO_OPTIONS)
 		return -1;
 
+	if (iph->frag_off & IP_MF)
+		return -1;
+
 	if (tcph->cwr || tcph->ece || tcph->urg || !tcph->ack
 	    || tcph->rst || tcph->syn || tcph->fin)
 		return -1;
-- 
1.5.5






             reply	other threads:[~2008-12-01  8:58 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-01  8:58 Jan-Bernd Themann [this message]
2008-12-01  9:41 ` [PATCH] lro: IP fragment checking David Miller
2008-12-01 17:50 ` Andrew Gallatin
2008-12-01 21:18   ` David Miller
2008-12-01 21:53     ` Andrew Gallatin
2008-12-01 22:09       ` Ben Hutchings
2008-12-02  0:02         ` Andrew Gallatin
2008-12-02  0:18           ` Ben Hutchings
2008-12-02 14:42             ` Andrew Gallatin
2008-12-02 15:18               ` Ben Hutchings
2008-12-02 15:36                 ` Andrew Gallatin
2008-12-02  0:07       ` David Miller
2008-12-02  0:19         ` Andrew Gallatin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4933A74F.3050809@de.ibm.com \
    --to=ossthema@de.ibm.com \
    --cc=davem@davemloft.net \
    --cc=hering2@de.ibm.com \
    --cc=jb.billaud@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=raisch@de.ibm.com \
    --cc=tklein@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).