From: Oliver Hartkopp <socketcan@hartkopp.net>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Oliver Hartkopp <oliver@hartkopp.net>,
David Miller <davem@davemloft.net>, Greg KH <greg@kroah.com>,
Kurt Van Dijck <kurt.van.dijck@eia.be>,
Linux Netdev List <netdev@vger.kernel.org>,
stable@kernel.org
Subject: Re: [PATCH] can: Fix CAN_(EFF|RTR)_FLAG handling in can_filter
Date: Mon, 01 Dec 2008 19:42:31 +0100 [thread overview]
Message-ID: <49343017.202@hartkopp.net> (raw)
In-Reply-To: <20081201175225.GA1835@uranus.ravnborg.org>
Sam Ravnborg wrote:
> On Mon, Dec 01, 2008 at 05:15:42PM +0100, Oliver Hartkopp wrote:
>
>>
>> Thanks to Kurt Van Dijck for pointing at this issue and for the review.
>>
>> Signed-Off-by: Oliver Hartkopp <oliver@hartkopp.net>
>> Acked-by: Kurt Van Dijck <kurt.van.dijck@eia.be>
>>
>
> If Kurt tested this patch then he should
> be credited with a "Tested-by:" tag.
>
> I recall he did but I deleted the thread from my can mailbox.
>
> Sam
>
Hi Sam,
i did some testing and posted the results of a first patch that went
into the final direction.
In
https://lists.berlios.de/pipermail/socketcan-core/2008-December/002117.html
Kurt gave a "Reviewed-by:" and in a later mail in
https://lists.berlios.de/pipermail/socketcan-core/2008-December/002119.html
he wrote "my Acked-by: still stands" for the final patch.
So i choosed "Acked-by:".
As Kurt went that deep into the code that he pointed me to the right
line and presented a first idea for a patch, an 'Acked-by:' for
confirming the final patch looked like an appropriate credit to me.
Regards,
Oliver
next prev parent reply other threads:[~2008-12-01 18:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20081128153317.GA3726@e-circ.dyndns.org>
2008-12-01 16:15 ` [PATCH] can: Fix CAN_(EFF|RTR)_FLAG handling in can_filter Oliver Hartkopp
2008-12-01 17:52 ` Sam Ravnborg
2008-12-01 18:42 ` Oliver Hartkopp [this message]
2008-12-01 18:52 ` Sam Ravnborg
2008-12-02 10:01 ` Kurt Van Dijck
2008-12-03 23:53 ` David Miller
2008-12-04 16:52 ` Oliver Hartkopp
2008-12-04 17:40 ` [PATCH net-2.6] can: omit received RTR frames for single ID filter lists Oliver Hartkopp
2008-12-04 23:01 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49343017.202@hartkopp.net \
--to=socketcan@hartkopp.net \
--cc=davem@davemloft.net \
--cc=greg@kroah.com \
--cc=kurt.van.dijck@eia.be \
--cc=netdev@vger.kernel.org \
--cc=oliver@hartkopp.net \
--cc=sam@ravnborg.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).